From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC2F2C2BB55 for ; Thu, 16 Apr 2020 02:16:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84F2E2072D for ; Thu, 16 Apr 2020 02:16:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731972AbgDPCQX (ORCPT ); Wed, 15 Apr 2020 22:16:23 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:2335 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728397AbgDPCQU (ORCPT ); Wed, 15 Apr 2020 22:16:20 -0400 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 39A5686E337A8F2A7A88; Thu, 16 Apr 2020 10:16:10 +0800 (CST) Received: from [127.0.0.1] (10.166.213.7) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.487.0; Thu, 16 Apr 2020 10:15:59 +0800 Subject: Re: [PATCH] x86/kvm: make steal_time static To: Paolo Bonzini , , , , , , , , , , , , CC: Hulk Robot References: <20200415084939.6367-1-yanaijie@huawei.com> From: Jason Yan Message-ID: <35c3890e-0c45-0dac-e9f0-f2a9446a387d@huawei.com> Date: Thu, 16 Apr 2020 10:15:58 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.166.213.7] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2020/4/15 22:42, Paolo Bonzini 写道: > On 15/04/20 10:49, Jason Yan wrote: >> Fix the following sparse warning: >> >> arch/x86/kernel/kvm.c:58:1: warning: symbol '__pcpu_scope_steal_time' >> was not declared. Should it be static? >> >> Reported-by: Hulk Robot >> Signed-off-by: Jason Yan >> --- >> arch/x86/kernel/kvm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c >> index 6efe0410fb72..f75010cde5d5 100644 >> --- a/arch/x86/kernel/kvm.c >> +++ b/arch/x86/kernel/kvm.c >> @@ -55,7 +55,7 @@ static int __init parse_no_stealacc(char *arg) >> early_param("no-steal-acc", parse_no_stealacc); >> >> static DEFINE_PER_CPU_DECRYPTED(struct kvm_vcpu_pv_apf_data, apf_reason) __aligned(64); >> -DEFINE_PER_CPU_DECRYPTED(struct kvm_steal_time, steal_time) __aligned(64) __visible; >> +static DEFINE_PER_CPU_DECRYPTED(struct kvm_steal_time, steal_time) __aligned(64) __visible; >> static int has_steal_clock = 0; >> >> /* >> > > Queued, thanks. > Sorry that I found 14e581c381b9 ("x86/kvm: Make steal_time visible") said that it is used by assembler code but I didn't find where. Please drop this patch if it's true. Sorry to make this trouble again. Thanks, Jason > Paolo > > > . >