linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sandhya Bankar <bankarsandhya512@gmail.com>
To: balbi@kernel.org, gregkh@linuxfoundation.org,
	r.baldyga@samsung.com, bankarsandhya512@gmail.com,
	saurabh.truth@gmail.com, peter.chen@freescale.com,
	Julia.Lawall@lip6.fr, linux-usb@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/3] usb: gr_udc: Remove unnecessary platform_set_drvdata().
Date: Wed, 11 May 2016 18:16:01 +0530	[thread overview]
Message-ID: <35c3927734e9696ba47cdc1e773805cf1fa7fb3e.1462967567.git.bankarsandhya512@gmail.com> (raw)
In-Reply-To: <cover.1462967567.git.bankarsandhya512@gmail.com>

Unnecessary [platform|pci]_set_drvdata() have been removed since the driver core clears the driver data to NULLafter device release or on probe failure. There is no need to manually clear the device driver data to NULL.

Signed-off-by: Sandhya Bankar <bankarsandhya512@gmail.com>
---
 drivers/usb/gadget/udc/gr_udc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c
index 39b7136..05f956c 100644
--- a/drivers/usb/gadget/udc/gr_udc.c
+++ b/drivers/usb/gadget/udc/gr_udc.c
@@ -2117,7 +2117,6 @@ static int gr_remove(struct platform_device *pdev)
 
 	gr_dfs_delete(dev);
 	dma_pool_destroy(dev->desc_pool);
-	platform_set_drvdata(pdev, NULL);
 
 	gr_free_request(&dev->epi[0].ep, &dev->ep0reqi->req);
 	gr_free_request(&dev->epo[0].ep, &dev->ep0reqo->req);
-- 
1.8.3.4

      parent reply	other threads:[~2016-05-11 19:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-11 12:35 [PATCH 0/3] Remove unnecessary pci_set_drvdata() and platform_set_drvdata() Sandhya Bankar
2016-05-11 12:38 ` [PATCH 1/3] usb: pci: Remove unnecessary pci_set_drvdata() Sandhya Bankar
2016-06-08  5:23   ` Greg KH
2016-05-11 12:42 ` [PATCH 2/3] usb: dwc3-keystone: Remove unnecessary platform_set_drvdata() Sandhya Bankar
2016-05-11 12:46 ` Sandhya Bankar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=35c3927734e9696ba47cdc1e773805cf1fa7fb3e.1462967567.git.bankarsandhya512@gmail.com \
    --to=bankarsandhya512@gmail.com \
    --cc=Julia.Lawall@lip6.fr \
    --cc=balbi@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter.chen@freescale.com \
    --cc=r.baldyga@samsung.com \
    --cc=saurabh.truth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).