From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D11D1C433DF for ; Thu, 21 May 2020 22:59:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A3CA020884 for ; Thu, 21 May 2020 22:59:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730730AbgEUW7W (ORCPT ); Thu, 21 May 2020 18:59:22 -0400 Received: from mga09.intel.com ([134.134.136.24]:2085 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730041AbgEUW7V (ORCPT ); Thu, 21 May 2020 18:59:21 -0400 IronPort-SDR: rTpUX+v5Hc2pq3n/OdYSloDEEu/rS9n6m+7pnHoHduc6+u/t3bxn/fBSMEtxJsRPMxp/8dhMV0 iUNinOrlMkLA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2020 15:59:20 -0700 IronPort-SDR: eVA4JMNYAhSkSjemmj7kQC1KSJo0SX42WpA2RqMlctZwO8R35JeFbPRT0ymL+Id0zifNd8bXm/ 8RWIhAI4W53w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,419,1583222400"; d="scan'208";a="309207695" Received: from yyu32-desk.sc.intel.com ([143.183.136.146]) by FMSMGA003.fm.intel.com with ESMTP; 21 May 2020 15:59:17 -0700 Message-ID: <35ce10628df75494569e5cf5bb6a3c537ff30cf2.camel@intel.com> Subject: Re: [RFC PATCH 4/5] selftest/x86: Fix sysret_rip with ENDBR From: Yu-cheng Yu To: Thomas Gleixner , x86@kernel.org, "H. Peter Anvin" , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Kees Cook , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Peter Zijlstra , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang Date: Thu, 21 May 2020 15:59:23 -0700 In-Reply-To: <878shlt1jw.fsf@nanos.tec.linutronix.de> References: <20200521211720.20236-1-yu-cheng.yu@intel.com> <20200521211720.20236-5-yu-cheng.yu@intel.com> <878shlt1jw.fsf@nanos.tec.linutronix.de> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.32.4 (3.32.4-1.fc30) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-05-21 at 23:34 +0200, Thomas Gleixner wrote: > Yu-cheng Yu writes: > > > Insert endbr64 to assembly code of sysret_rip. > > This changelog explains what the patch does, but not the WHY. It also > lacks any information why this is harmless for !CET enabled systems. > > > Signed-off-by: Yu-cheng Yu > > --- > > Please consult Dave Hansen about the void between your Signed-off-by > and the '---' line. > > Thanks, > > tglx Thanks! I will work on it. Yu-cheng