From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB69DC432BE for ; Mon, 26 Jul 2021 13:43:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C1B9060241 for ; Mon, 26 Jul 2021 13:43:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233903AbhGZNCq (ORCPT ); Mon, 26 Jul 2021 09:02:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:45168 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234356AbhGZNCC (ORCPT ); Mon, 26 Jul 2021 09:02:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1627306950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DbUVtvqYLIV2IExPgkbfEc3dRpkF1ai0qjs2lZ3kNnE=; b=XxT+eThnIsT2vAcPTRRP3rwn2IXdcRneeMwKwbJEnMhLeDQ6QFd7bQGKK5dIW05cQVXEVj XJ7k4NWTjs80+ninQped+T2zfIl4y8HWlNEnn9oyLEm2GJvweWDls+6qgtaThvY36mDSKW TRHjgnMYdcVODCzoWEZx2uh35vZR1t8= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-203-TOmbLaokMOSH8uwoBq0E4g-1; Mon, 26 Jul 2021 09:42:27 -0400 X-MC-Unique: TOmbLaokMOSH8uwoBq0E4g-1 Received: by mail-ed1-f71.google.com with SMTP id h16-20020aa7de100000b02903a6620f87feso4758532edv.18 for ; Mon, 26 Jul 2021 06:42:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DbUVtvqYLIV2IExPgkbfEc3dRpkF1ai0qjs2lZ3kNnE=; b=FcANrjfilmOUtuxeuNUB2f1+a6Yc5ZCgfG9KB16TfgtP9yEzaAwwnidAlBQloMVIc6 +KWcN8y4w5xhLG4Nhsd3qeMp/P78DzSmrQKBTYW2LOOrA2+6OknRBytIiFfOuSzMNKHA 03jKuzJzfY+SuGWDJb8hTiUDG6+gY72iouQJ6I3fJrYu/uaPJaRuUz3BoI9W3w6IDoar dL1l00UaYG+bIxdO42hJXC9o0AJiB23EJSreeZmD5wiyPsXbTJukukh4aOMLJ+iSjaaD DRU6tEWpB8rJJW+FQB2qG2G+euO3E/6xyuYEevIrKFhA0j1qU658vbU+Tq/AI7EheAEf tz+w== X-Gm-Message-State: AOAM530e8Jb5ceH99L5+AMYto4PvXiqqJ7P1+FyWudXGXTllMRdZMeMq 0pTNOH4LZXP7ha4X9kHvvHFkVbIchY1lV9MktW96E4FmczoYBFDfw5DK8aq8UqZVDZ2gVDaZAnq h3XWEzQxh0aymre0KL3DrGIye X-Received: by 2002:a05:6402:31a4:: with SMTP id dj4mr10088526edb.350.1627306946112; Mon, 26 Jul 2021 06:42:26 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzaPhxnXEkX5ZgOuE+meod+XZ3vfb4y3Q1rF5NA9yq0QtYo6bz/rfrexS5Pw1vje0rYXFomiQ== X-Received: by 2002:a05:6402:31a4:: with SMTP id dj4mr10088510edb.350.1627306945972; Mon, 26 Jul 2021 06:42:25 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id k21sm18837408edo.41.2021.07.26.06.42.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jul 2021 06:42:25 -0700 (PDT) Subject: Re: [PATCH v2 2/9] KVM: Introduce kvm_get_kvm_safe() To: Peter Xu , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Cc: Vitaly Kuznetsov , Sean Christopherson , Maxim Levitsky References: <20210625153214.43106-1-peterx@redhat.com> <20210625153214.43106-3-peterx@redhat.com> From: Paolo Bonzini Message-ID: <35d133ab-5f21-7693-51ae-1a6ae81e76f4@redhat.com> Date: Mon, 26 Jul 2021 15:42:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210625153214.43106-3-peterx@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/06/21 17:32, Peter Xu wrote: > - /* The debugfs files are a reference to the kvm struct which > - * is still valid when kvm_destroy_vm is called. > - * To avoid the race between open and the removal of the debugfs > - * directory we test against the users count. > - */ > - if (!refcount_inc_not_zero(&stat_data->kvm Better keep the comment here (but nothing to do on your part). Paolo