From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7694C433E1 for ; Fri, 10 Jul 2020 04:41:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9BA8720720 for ; Fri, 10 Jul 2020 04:41:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="qHk3nOy8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726794AbgGJElk (ORCPT ); Fri, 10 Jul 2020 00:41:40 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:34087 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725851AbgGJElj (ORCPT ); Fri, 10 Jul 2020 00:41:39 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1594356099; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=OVjdWKa1KuoweAYyp7yqaqBQuL2K9SPqsc9S8yXQW08=; b=qHk3nOy8fqYNkmRKDvY9alyunxSNRhpHZFWdxJwIJLq90nwe4mplY/uMdxQrWAGAZ86bo/5L sxnIWNipb8HHFC1utLTiNbhFCIB+4jZCpDpudoJI/xirHZGiDCQNpRViMy8+4gsd+Pgc8IaT 4QFr+6+295iFrx4tfymzMOrXD4w= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n08.prod.us-west-2.postgun.com with SMTP id 5f07f17ed8ca07a5739d5751 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 10 Jul 2020 04:41:34 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 5BC7DC43387; Fri, 10 Jul 2020 04:41:34 +0000 (UTC) Received: from [192.168.0.7] (unknown [183.83.138.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: akashast) by smtp.codeaurora.org (Postfix) with ESMTPSA id B0925C433CA; Fri, 10 Jul 2020 04:41:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B0925C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=akashast@codeaurora.org Subject: Re: [PATCH v2] spi: spi-geni-qcom: Set the clock properly at runtime resume To: Douglas Anderson , Mark Brown , Andy Gross , Bjorn Andersson Cc: mkshah@codeaurora.org, georgi.djakov@linaro.org, swboyd@chromium.org, linux-arm-msm@vger.kernel.org, mka@chromium.org, ctheegal@codeaurora.org, Rajendra Nayak , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org References: <20200709074037.v2.1.I0b701fc23eca911a5bde4ae4fa7f97543d7f960e@changeid> From: Akash Asthana Message-ID: <35e1b2de-b3ee-95f4-c7ab-dfa8544b744c@codeaurora.org> Date: Fri, 10 Jul 2020 10:11:22 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200709074037.v2.1.I0b701fc23eca911a5bde4ae4fa7f97543d7f960e@changeid> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/9/2020 8:10 PM, Douglas Anderson wrote: > In the patch ("spi: spi-geni-qcom: Avoid clock setting if not needed") > we avoid a whole pile of clock code. As part of that, we should have > restored the clock at runtime resume. Do that. > > It turns out that, at least with today's configurations, this doesn't > actually matter. That's because none of the current device trees have > an OPP table for geni SPI yet. That makes dev_pm_opp_set_rate(dev, 0) > a no-op. This is why it wasn't noticed in the testing of the original > patch. It's still a good idea to fix, though. Reviewed-by: Akash Asthana -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,\na Linux Foundation Collaborative Project