From: Tiezhu Yang <yangtiezhu@loongson.cn>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>,
linux-kernel@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH 1/2] perf tools: check libasan and libubsan in Makefile.config
Date: Wed, 3 Jun 2020 10:01:27 +0800 [thread overview]
Message-ID: <35e55bec-1f8a-0e8f-798b-bab51ad30797@loongson.cn> (raw)
In-Reply-To: <20200602141551.GC1169993@krava>
On 06/02/2020 10:15 PM, Jiri Olsa wrote:
> On Tue, Jun 02, 2020 at 12:15:03PM +0800, Tiezhu Yang wrote:
>> When build perf with ASan or UBSan, if libasan or libubsan can not find,
>> the feature-glibc is 0 and there exists the following error log which is
>> wrong, because we can find gnu/libc-version.h in /usr/include, glibc-devel
>> is also installed.
>>
>> [yangtiezhu@linux perf]$ make DEBUG=1 EXTRA_CFLAGS='-fno-omit-frame-pointer -fsanitize=address'
>> BUILD: Doing 'make -j4' parallel build
>> HOSTCC fixdep.o
>> HOSTLD fixdep-in.o
>> LINK fixdep
>> <stdin>:1:0: warning: -fsanitize=address and -fsanitize=kernel-address are not supported for this target
>> <stdin>:1:0: warning: -fsanitize=address not supported for this target
>>
>> Auto-detecting system features:
>> ... dwarf: [ OFF ]
>> ... dwarf_getlocations: [ OFF ]
>> ... glibc: [ OFF ]
>> ... gtk2: [ OFF ]
>> ... libaudit: [ OFF ]
>> ... libbfd: [ OFF ]
>> ... libcap: [ OFF ]
>> ... libelf: [ OFF ]
>> ... libnuma: [ OFF ]
>> ... numa_num_possible_cpus: [ OFF ]
>> ... libperl: [ OFF ]
>> ... libpython: [ OFF ]
>> ... libcrypto: [ OFF ]
>> ... libunwind: [ OFF ]
>> ... libdw-dwarf-unwind: [ OFF ]
>> ... zlib: [ OFF ]
>> ... lzma: [ OFF ]
>> ... get_cpuid: [ OFF ]
>> ... bpf: [ OFF ]
>> ... libaio: [ OFF ]
>> ... libzstd: [ OFF ]
>> ... disassembler-four-args: [ OFF ]
>>
>> Makefile.config:393: *** No gnu/libc-version.h found, please install glibc-dev[el]. Stop.
>> Makefile.perf:224: recipe for target 'sub-make' failed
>> make[1]: *** [sub-make] Error 2
>> Makefile:69: recipe for target 'all' failed
>> make: *** [all] Error 2
>> [yangtiezhu@linux perf]$ ls /usr/include/gnu/libc-version.h
>> /usr/include/gnu/libc-version.h
>>
>> After install libasan and libubsan, the feature-glibc is 1 and the build
>> process is success, so the cause is related with libasan or libubsan, we
>> should check them and print an error log to reflect the reality.
>>
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
>> ---
>> tools/perf/Makefile.config | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/tools/perf/Makefile.config b/tools/perf/Makefile.config
>> index 12a8204..b699d21 100644
>> --- a/tools/perf/Makefile.config
>> +++ b/tools/perf/Makefile.config
>> @@ -387,6 +387,12 @@ else
>> NO_LIBBPF := 1
>> NO_JVMTI := 1
>> else
>> + ifneq ($(shell ldconfig -p | grep libasan >/dev/null 2>&1; echo $$?), 0)
>> + msg := $(error No libasan found, please install libasan);
>> + endif
>> + ifneq ($(shell ldconfig -p | grep libubsan >/dev/null 2>&1; echo $$?), 0)
>> + msg := $(error No libubsan found, please install libubsan);
>> + endif
> hum, would it be better to have check for this in tools/build/features?
Hi Jiri,
Thanks for your suggestion.
Do you mean that it is better to add this check at the end of file
tools/build/Makefile.feature?
>
> jirka
>
>> ifneq ($(filter s% -static%,$(LDFLAGS),),)
>> msg := $(error No static glibc found, please install glibc-static);
>> else
>> --
>> 2.1.0
>>
next prev parent reply other threads:[~2020-06-03 2:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 4:15 [PATCH 1/2] perf tools: check libasan and libubsan in Makefile.config Tiezhu Yang
2020-06-02 4:15 ` [PATCH 2/2] perf tools: Remove some duplicated includes Tiezhu Yang
2020-06-02 14:10 ` Arnaldo Carvalho de Melo
2020-06-02 14:11 ` [PATCH 1/2] perf tools: check libasan and libubsan in Makefile.config Arnaldo Carvalho de Melo
2020-06-02 14:15 ` Jiri Olsa
2020-06-03 2:01 ` Tiezhu Yang [this message]
2020-06-04 8:34 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35e55bec-1f8a-0e8f-798b-bab51ad30797@loongson.cn \
--to=yangtiezhu@loongson.cn \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).