From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5010AC433DF for ; Wed, 13 May 2020 23:16:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4890D2053B for ; Wed, 13 May 2020 23:16:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UQx3BW0o" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732513AbgEMXQU (ORCPT ); Wed, 13 May 2020 19:16:20 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:34718 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1732408AbgEMXQT (ORCPT ); Wed, 13 May 2020 19:16:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589411778; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=T5AJR2WaKjGAcCSypFEIypZ7FO4lpByrCMG2GJChQq0=; b=UQx3BW0oP9w1XKMu9tpT611fvfgXPLVD/8Qd3XbbDoZ2hnqOlvBq1kJbVuiK+Tf/2uWn+d jTzny5dzrA9sPiuLX0Er4BJ/X62a0BnSmIbZ+l93dRw4mdH5bEq+N43h9Pd7RZ1PfsfuCp LXzoRWxdkuQq2DMVDy4JDR+flsRdbu4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-146-E8cGbxnwNDOYTGRpB5xLtA-1; Wed, 13 May 2020 19:16:16 -0400 X-MC-Unique: E8cGbxnwNDOYTGRpB5xLtA-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id F20E7461; Wed, 13 May 2020 23:16:14 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-112-59.rdu2.redhat.com [10.10.112.59]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5221F600DB; Wed, 13 May 2020 23:16:13 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <158932282880.2885325.2688622278854566047.stgit@warthog.procyon.org.uk> To: Paul Moore Cc: dhowells@redhat.com, Stephen Smalley , Jarkko Sakkinen , Casey Schaufler , keyrings@vger.kernel.org, selinux@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] keys: Make the KEY_NEED_* perms an enum rather than a mask MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3611714.1589411772.1@warthog.procyon.org.uk> Date: Thu, 14 May 2020 00:16:12 +0100 Message-ID: <3611715.1589411772@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paul Moore wrote: > > + case KEY_NEED_VIEW: perm = KEY__VIEW; break; > > + case KEY_NEED_READ: perm = KEY__READ; break; > > + case KEY_NEED_WRITE: perm = KEY__WRITE; break; > > + case KEY_NEED_SEARCH: perm = KEY__SEARCH; break; > > + case KEY_NEED_LINK: perm = KEY__LINK; break; > > + case KEY_NEED_SETATTR: perm = KEY__SETATTR; break; > > Please don't put the case statements all on one line, use the more > traditional multi-line format. For example: > > case KEY_NEED_SETATTR: > perm = KEY__SETATTR; > break; Tabulation was invented something like 6000 years ago for just this kind of purpose;-) It's less readable your way, but whatever... David