From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752322AbdA2Ubg convert rfc822-to-8bit (ORCPT ); Sun, 29 Jan 2017 15:31:36 -0500 Received: from gloria.sntech.de ([95.129.55.99]:45718 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751948AbdA2UbT (ORCPT ); Sun, 29 Jan 2017 15:31:19 -0500 From: Heiko Stuebner To: Alexander Kochetkov Cc: Daniel Lezcano , LKML , devicetree@vger.kernel.org, LAK , linux-rockchip@lists.infradead.org, Thomas Gleixner , Mark Rutland , Rob Herring , Russell King , Caesar Wang , Huang Tao Subject: Re: [PATCH v5 5/8] clocksource/drivers/rockchip_timer: split bc_timer into rk_timer and rk_clock_event_device Date: Sun, 29 Jan 2017 21:30:13 +0100 Message-ID: <3616490.5RPja2j5kp@phil> User-Agent: KMail/5.2.3 (Linux/4.8.0-2-amd64; KDE/5.27.0; x86_64; ; ) In-Reply-To: <14EAE124-D504-4480-A6D4-EB7EFFC3C561@gmail.com> References: <1485260203-14216-1-git-send-email-al.kochet@gmail.com> <3890508.0j97LNriXL@diego> <14EAE124-D504-4480-A6D4-EB7EFFC3C561@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Alexander, Am Dienstag, 24. Januar 2017, 18:16:20 CET schrieb Alexander Kochetkov: > > 24 янв. 2017 г., в 18:02, Heiko Stübner написал(а): > > > > Please don't add Reviewed-by tags without explicit mention of them by > > reviewers. (Also it's spelled wrong). > > > > I haven't looked that deeply into the driver itself and the changes made > > to > > feel comfortable with a "Reviewed-by". > > Than I posted another linux code I was asked to add such tags (and others) > to add credits to people. > > Sorry for that. no problem. In general people reviewing patches will respond to the patch with tags they are comfortable with being added. And a Reviewed-by is a pretty strong tag, indicating that some thought went into reviewing a specific patch, which I hadn't done with my cursory glance at the time :-) Heiko