linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Can Guo <cang@codeaurora.org>
To: Bean Huo <huobean@gmail.com>
Cc: alim.akhtar@samsung.com, avri.altman@wdc.com,
	asutoshd@codeaurora.org, jejb@linux.ibm.com,
	martin.petersen@oracle.com, stanley.chu@mediatek.com,
	beanhuo@micron.com, bvanassche@acm.org, tomas.winkler@intel.com,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/4] scsi: ufs: Let UPIU completion trace print RSP UPIU header
Date: Wed, 02 Jun 2021 10:34:05 +0800	[thread overview]
Message-ID: <361f7611bc5193694487831bfd912ad1@codeaurora.org> (raw)
In-Reply-To: <20210531104308.391842-3-huobean@gmail.com>

On 2021-05-31 18:43, Bean Huo wrote:
> From: Bean Huo <beanhuo@micron.com>
> 
> The current UPIU completion event trace still prints the COMMAND UPIU
> header, rather than the RSP UPIU header. This makes UPIU command trace
> useless in problem shooting in case we receive a trace log from the
> customer/field.
> 
> There are two important fields in RSP UPIU:
>  1. The response field, which indicates the UFS defined overall success
>     or failure of the series of Command, Data and RESPONSE UPIU’s that
>     make up the execution of a task.
>  2. The Status field, which contains the command set specific status 
> for
>     a specific command issued by the initiator device.
> 
> Before this patch, the UPIU paired trace events:
> 
> ufshcd_upiu: send_req: fe3b0000.ufs: HDR:01 20 00 1c 00 00 00 00 00 00
> 00 00, CDB:3b e1 00 00 00 00 00 00 30 00 00 00 00 00 00 00
> ufshcd_upiu: complete_rsp: fe3b0000.ufs: HDR:01 20 00 1c 00 00 00 00
> 00 00 00 00, CDB:3b e1 00 00 00 00 00 00 30 00 00 00 00 00 00 00
> 
> After the patch:
> 
> ufshcd_upiu: send_req: fe3b0000.ufs: HDR:01 20 00 1c 00 00 00 00 00 00
> 00 00, CDB:3b e1 00 00 00 00 00 00 30 00 00 00 00 00 00 00
> ufshcd_upiu: complete_rsp: fe3b0000.ufs: HDR:21 00 00 1c 00 00 00 00
> 00 00 00 00, CDB:3b e1 00 00 00 00 00 00 30 00 00 00 00 00 00 00
> 
> Signed-off-by: Bean Huo <beanhuo@micron.com>
> ---
>  drivers/scsi/ufs/ufshcd.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 85590d3a719e..c5754d5486c9 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -302,11 +302,17 @@ static void ufshcd_add_cmd_upiu_trace(struct
> ufs_hba *hba, unsigned int tag,
>  				      enum ufs_trace_str_t str_t)
>  {
>  	struct utp_upiu_req *rq = hba->lrb[tag].ucd_req_ptr;
> +	struct utp_upiu_header *header;
> 
>  	if (!trace_ufshcd_upiu_enabled())
>  		return;
> 
> -	trace_ufshcd_upiu(dev_name(hba->dev), str_t, &rq->header, 
> &rq->sc.cdb,
> +	if (str_t == UFS_CMD_SEND)
> +		header = &rq->header;
> +	else
> +		header = &hba->lrb[tag].ucd_rsp_ptr->header;
> +
> +	trace_ufshcd_upiu(dev_name(hba->dev), str_t, header, &rq->sc.cdb,
>  			  UFS_TSF_CDB);
>  }

Reviewed-by: Can Guo <cang@codeaurora.org>

  reply	other threads:[~2021-06-02  2:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-31 10:43 [PATCH v2 0/4] Several minor changes for UFS Bean Huo
2021-05-31 10:43 ` [PATCH v2 1/4] scsi: ufs: Cleanup ufshcd_add_command_trace() Bean Huo
2021-06-02  2:35   ` Can Guo
2021-05-31 10:43 ` [PATCH v2 2/4] scsi: ufs: Let UPIU completion trace print RSP UPIU header Bean Huo
2021-06-02  2:34   ` Can Guo [this message]
2021-05-31 10:43 ` [PATCH v2 3/4] scsi: ufs: Let command trace only for the cmd != null case Bean Huo
2021-06-02  2:32   ` Can Guo
2021-05-31 10:43 ` [PATCH v2 4/4] scsi: ufs: Use UPIU query trace in devman_upiu_cmd Bean Huo
2021-06-02  2:29   ` Can Guo
2021-06-02 21:05     ` Bean Huo
2021-06-04  2:36       ` Can Guo
2021-06-08  2:36 ` [PATCH v2 0/4] Several minor changes for UFS Martin K. Petersen
2021-06-16  3:48 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=361f7611bc5193694487831bfd912ad1@codeaurora.org \
    --to=cang@codeaurora.org \
    --cc=alim.akhtar@samsung.com \
    --cc=asutoshd@codeaurora.org \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=huobean@gmail.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stanley.chu@mediatek.com \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).