From: Jacky Huang <ychuang3@nuvoton.com>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-clk@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <ychuang570808@gmail.com>,
<sboyd@kernel.org>, <krzk+dt@kernel.org>, <arnd@arndb.de>,
<olof@lixom.net>, <will@kernel.org>, <soc@kernel.org>,
<cfli0@nuvoton.com>
Subject: Re: [PATCH v3 5/5] dt-bindings: arm: Add initial bindings for Nuvoton Platform
Date: Tue, 26 Apr 2022 08:47:10 +0800 [thread overview]
Message-ID: <363b08bd-098d-5c6b-eebd-6740aeb70f29@nuvoton.com> (raw)
In-Reply-To: <Ymc6hK0Z/t3IKF3z@robh.at.kernel.org>
On 2022/4/26 上午 08:19, Rob Herring wrote:
> On Thu, Apr 21, 2022 at 04:13:20PM +0800, Jacky Huang wrote:
>>
>> On 2022/4/21 下午 04:05, Krzysztof Kozlowski wrote:
>>> On 21/04/2022 10:04, Jacky Huang wrote:
>>>> On 2022/4/21 下午 02:56, Krzysztof Kozlowski wrote:
>>>>> On 21/04/2022 08:39, Jacky Huang wrote:
>>>>>> On 2022/4/18 下午 08:11, Krzysztof Kozlowski wrote:
>>>>>>> On 18/04/2022 10:27, Jacky Huang wrote:
>>>>>>>> +properties:
>>>>>>>> + $nodename:
>>>>>>>> + const: '/'
>>>>>>>> + compatible:
>>>>>>>> + items:
>>>>>>>> + - enum:
>>>>>>>> + - nuvoton,ma35d1
>>>>>>>> + - nuvoton,ma35d1-evb
>>>>>>>> + - nuvoton,ma35d1-iot
>>>>>>>> + - nuvoton,ma35d1-som512
>>>>>>>> + - nuvoton,ma35d1-som1g
>>>>>>> This does not match your DTS and does not look reasonable (SoC
>>>>>>> compatible should not be part of this enum). Check some other board
>>>>>>> bindings for examples.
>>>>>>>
>>>>>>>
>>>>>>> Best regards,
>>>>>>> Krzysztof
>>>>>> I would like to modify it as follows:
>>>>>>
>>>>>> description: |
>>>>>> Boards with an ARMv8 based Nuvoton SoC shall have the following
>>>>>> properties.
>>>>>>
>>>>>> properties:
>>>>>> $nodename:
>>>>>> const: '/'
>>>>>> compatible:
>>>>>> oneOf:
>>>>>>
>>>>>> - description: MA35D1 evaluation board
>>>>>> items:
>>>>>> - const: nuvoton,ma35d1-evb
>>>>>> - const: nuvoton,ma35d1
>>>>>>
>>>>>> - description: MA35D1 IoT board
>>>>>> items:
>>>>>> - const: nuvoton,ma35d1-iot
>>>>> Instead just enum with all board compatibles.
>>>> How about to modify it as the follows:
>>>>
>>>> compatible:
>>>> oneOf:
>>>>
>>>> - description: MA35D1 evaluation board
>>>> items:
>>>> - enum:
>>>> - nuvoton,ma35d1-evb
>>>> - const: nuvoton,ma35d1
>>>>
>>>> - description: MA35D1 IoT board
>>>> items:
>>>> - enum:
>>>> - nuvoton,ma35d1-iot
>>>> - const: nuvoton,ma35d1
>>>>
>>>> - description: MA35D1 SOM board
>>>> items:
>>>> - enum:
>>>> - nuvoton,ma35d1-som512
>>>> - nuvoton,ma35d1-som1g
>>>> - const: nuvoton,ma35d1
>>>>
>>> It's still almost the same. All boards together. You can add a comment
>>> next to the compatible if you want some user-friendly name.
>>>
>>>
>>> Best regards,
>>> Krzysztof
>> OK, I got it. Like this,
>>
>> compatible:
>> oneOf:
>>
>> - description: MA35D1 based boards
>> items:
>> - enum:
>> - nuvoton,ma35d1-evb
>> - nuvoton,ma35d1-iot
>> - nuvoton,ma35d1-som512
>> - nuvoton,ma35d1-som1g
> The memory node distinguishes how much memory. Is the board different
> for the SoM? If not, combine these to 1.
Yes, I can make two dts files (som512 and som1g) with binding to the
same som board.
I will modify it as a single nuvoton,ma35d1-som board.
Thank you.
>> - const: nuvoton,ma35d1
>>
>> Sincerely,
>> Jacky Huang
>>
>>
>>
Sincerely,
Jacky Huang
prev parent reply other threads:[~2022-04-26 0:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 8:27 [PATCH v3 0/5] Add initial support for MA35D1 SoC Jacky Huang
2022-04-18 8:27 ` [PATCH v3 1/5] dt-bindings: clock: add binding for MA35D1 clock controller Jacky Huang
2022-04-18 12:09 ` Krzysztof Kozlowski
2022-04-18 8:27 ` [PATCH v3 2/5] dt-bindings: clock: Document MA35D1 clock controller bindings Jacky Huang
2022-04-18 12:18 ` Krzysztof Kozlowski
2022-04-19 10:12 ` Jacky Huang
2022-04-19 10:39 ` Krzysztof Kozlowski
2022-04-19 10:49 ` Jacky Huang
2022-04-18 13:35 ` Rob Herring
2022-04-19 8:49 ` Jacky Huang
2022-04-18 8:27 ` [PATCH v3 3/5] arm64: dts: nuvoton: Add initial support for MA35D1 Jacky Huang
2022-04-18 12:20 ` Krzysztof Kozlowski
2022-04-21 6:41 ` Jacky Huang
2022-04-18 8:27 ` [PATCH v3 4/5] arm64: Kconfig: nuvoton: Introduce CONFIG_ARCH_NUVOTON Jacky Huang
2022-04-18 8:27 ` [PATCH v3 5/5] dt-bindings: arm: Add initial bindings for Nuvoton Platform Jacky Huang
2022-04-18 12:11 ` Krzysztof Kozlowski
2022-04-21 6:39 ` Jacky Huang
2022-04-21 6:56 ` Krzysztof Kozlowski
2022-04-21 8:04 ` Jacky Huang
2022-04-21 8:05 ` Krzysztof Kozlowski
2022-04-21 8:13 ` Jacky Huang
2022-04-21 8:33 ` Krzysztof Kozlowski
2022-04-26 0:19 ` Rob Herring
2022-04-26 0:47 ` Jacky Huang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=363b08bd-098d-5c6b-eebd-6740aeb70f29@nuvoton.com \
--to=ychuang3@nuvoton.com \
--cc=arnd@arndb.de \
--cc=cfli0@nuvoton.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=soc@kernel.org \
--cc=will@kernel.org \
--cc=ychuang570808@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).