From: Paolo Bonzini <pbonzini@redhat.com>
To: Tao Xu <tao3.xu@intel.com>, Xiaoyao Li <xiaoyao.li@intel.com>
Cc: Maxim Levitsky <mlevitsk@redhat.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] kvm/x86: don't expose MSR_IA32_UMWAIT_CONTROL unconditionally
Date: Thu, 21 May 2020 10:40:21 +0200 [thread overview]
Message-ID: <3642373d-8d1d-de80-d3db-e835a8f29449@redhat.com> (raw)
In-Reply-To: <6c99b807-fe67-23b5-3332-b7200bf5d639@intel.com>
On 21/05/20 08:44, Tao Xu wrote:
>
> I am sorry, I mean:
> By default, we don't expose WAITPKG to guest. For QEMU, we can use
> "-overcommit cpu-pm=on" to use WAITPKG.
But UMONITOR, UMWAIT and TPAUSE are not NOPs on older processors (which
I should have checked before committing your patch, I admit). So you
have broken "-cpu host -overcommit cpu-pm=on" on any processor that
doesn't have WAITPKG. I'll send a patch.
Paolo
next prev parent reply other threads:[~2020-05-21 8:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 16:07 [PATCH 0/2] Fix breakage from adding MSR_IA32_UMWAIT_CONTROL Maxim Levitsky
2020-05-20 16:07 ` [PATCH 1/2] kvm: cosmetic: remove wrong braces in kvm_init_msr_list switch Maxim Levitsky
2020-05-20 16:23 ` Vitaly Kuznetsov
2020-05-20 16:07 ` [PATCH 2/2] kvm/x86: don't expose MSR_IA32_UMWAIT_CONTROL unconditionally Maxim Levitsky
2020-05-20 16:33 ` Vitaly Kuznetsov
2020-05-20 16:56 ` Maxim Levitsky
2020-05-20 17:15 ` Vitaly Kuznetsov
2020-05-20 17:39 ` Maxim Levitsky
2020-05-21 8:03 ` Xiaoyao Li
2020-05-20 21:05 ` Paolo Bonzini
2020-05-20 21:09 ` Maxim Levitsky
2020-05-21 4:33 ` Xiaoyao Li
2020-05-21 5:28 ` Tao Xu
2020-05-21 6:37 ` Xiaoyao Li
2020-05-21 6:44 ` Tao Xu
2020-05-21 8:40 ` Paolo Bonzini [this message]
2020-06-30 13:41 ` Maxim Levitsky
2020-05-21 8:24 ` Paolo Bonzini
2020-05-23 16:14 [PATCH 0/2] Fix issue with not starting nesting guests on my system Maxim Levitsky
2020-05-23 16:14 ` [PATCH 2/2] kvm/x86: don't expose MSR_IA32_UMWAIT_CONTROL unconditionally Maxim Levitsky
2020-05-27 1:21 ` Sean Christopherson
2020-05-27 15:17 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3642373d-8d1d-de80-d3db-e835a8f29449@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlevitsk@redhat.com \
--cc=tao3.xu@intel.com \
--cc=xiaoyao.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).