From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BEBBC43331 for ; Wed, 13 Nov 2019 11:06:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 507EF222BD for ; Wed, 13 Nov 2019 11:06:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="X8HMahfV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727717AbfKMLGy (ORCPT ); Wed, 13 Nov 2019 06:06:54 -0500 Received: from lelv0142.ext.ti.com ([198.47.23.249]:51562 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726165AbfKMLGy (ORCPT ); Wed, 13 Nov 2019 06:06:54 -0500 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id xADB6XsH114264; Wed, 13 Nov 2019 05:06:33 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1573643193; bh=gSAJ+1KpkGy+Q87mlI/tRdXnYA0Fp4XtcaHY6UfujOc=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=X8HMahfV7qdJsgEfNTulOHlp4TJPpj8nc0CC/YuUcqC+GwSC256cdrxmxhENY2e04 61oz5VO/LASJhQ6t8VoztScF/KDh/y35LJ2aiXKQVOJyZT17XY2kNpp2lcswkz8cfF dRgCdPrCHiN/hq8y1ejhy1NM/P4Z2Pqh2ELfzubI= Received: from DFLE102.ent.ti.com (dfle102.ent.ti.com [10.64.6.23]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id xADB6Wu9096144 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 13 Nov 2019 05:06:32 -0600 Received: from DFLE109.ent.ti.com (10.64.6.30) by DFLE102.ent.ti.com (10.64.6.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Wed, 13 Nov 2019 05:06:15 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE109.ent.ti.com (10.64.6.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Wed, 13 Nov 2019 05:06:15 -0600 Received: from [172.24.190.117] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id xADB6T5G127091; Wed, 13 Nov 2019 05:06:29 -0600 Subject: Re: [PATCH] irqchip/ti-sci-inta: Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)) To: Marc Zyngier CC: Markus Elfring , , Jason Cooper , Nishanth Menon , Santosh Shilimkar , Tero Kristo , Thomas Gleixner , LKML , References: <776b7135-26af-df7d-c3a9-4339f7bf1f15@web.de> <670cd9a2-2083-bb5e-7bfc-58d5c90ec756@ti.com> <29a69991ec7726d133e54a2891159e86@www.loen.fr> From: Lokesh Vutla Message-ID: <3642882b-edab-1667-f370-47e8358edc82@ti.com> Date: Wed, 13 Nov 2019 16:35:34 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <29a69991ec7726d133e54a2891159e86@www.loen.fr> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/11/19 3:45 PM, Marc Zyngier wrote: > On 2019-11-11 04:45, Lokesh Vutla wrote: >> On 05/11/19 5:00 PM, Markus Elfring wrote: >>> From: Markus Elfring >>> Date: Tue, 5 Nov 2019 12:19:39 +0100 >>> >>> A coccicheck run provided information like the following. >>> >>> drivers/irqchip/irq-ti-sci-inta.c:250:9-16: WARNING: ERR_CAST can be used >>> with vint_desc. >>> >>> Generated by: scripts/coccinelle/api/err_cast.cocci >>> >>> Thus adjust the exception handling in one if branch. >>> >>> Fixes: 9f1463b86c13277d0bd88d5ee359577ef40f4da7 ("irqchip/ti-sci-inta: Add >>> support for Interrupt Aggregator driver") >> >> Fixes: 9f1463b86c13 ("irqchip/ti-sci-inta: Add support for Interrupt >> Aggregator driver") > > I fundamentally disagree with the "Fixes:" tag. This isn't a fix, > just a minor readability improvement. Flagging things as "Fixes:" > ends up triggering all kind of unnecessary backports to -stable. > >> With this: Fine with me. Please drop the fixes tag. Thanks and regards. Lokesh >> >> Reviewed-by: Lokesh Vutla > > I'll otherwise take this patch in -next. > > Thanks, > >         M.