From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>,
Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: <vkoul@kernel.org>, <dan.j.williams@intel.com>,
<dmaengine@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<tony@atomide.com>, <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1
Date: Tue, 18 Dec 2018 12:11:06 +0200 [thread overview]
Message-ID: <36444432-a34c-826f-6efa-109921da69b7@ti.com> (raw)
In-Reply-To: <20181217191657.GB7288@darkstar.musicnaut.iki.fi>
On 17/12/2018 21.16, Aaro Koskinen wrote:
> On Thu, Nov 22, 2018 at 03:12:36PM +0000, Russell King - ARM Linux wrote:
>> Also we can't deal with the omap_set_dma_dest_burst_mode() setting -
>> DMAengine always uses a 64 byte burst, but udc wants a smaller burst
>> setting. Does this matter?
>
> Looking at OMAP1 docs, it seems it supports only 16 bytes. Then checking
> DMAengine code, I don't think these CSDP bit values are not valid
> for OMAP1:
>
> CSDP_SRC_BURST_1 = 0 << 7,
> CSDP_SRC_BURST_16 = 1 << 7,
> CSDP_SRC_BURST_32 = 2 << 7,
> CSDP_SRC_BURST_64 = 3 << 7,
>
> From TI SPRU674 document, pages 50-51:
>
> 0 single access (no burst)
> 1 single access (no burst)
> 2 burst 4
In omap1510 it is 4 x data_type
In omap1610/1710 it is 4 x data_type (only data_type == 32bit is supported)
From omap2420+ 32 bytes (8x32bit/4x64bit)
So for OMAP1 we need to have different handling of the burst:
only enable if data_type is 32bit.
> 3 reserved (do not use this setting)
>
> So if CSDP_SRC_BURST_64 (3) gets programmed OMAP1, I wonder what is the
> end result, no burst or burst 4...
>
> A.
>
- Péter
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2018-12-18 10:10 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-19 10:40 [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1 Peter Ujfalusi
2018-11-19 18:46 ` Aaro Koskinen
2018-11-20 7:28 ` Peter Ujfalusi
2018-11-20 21:04 ` Aaro Koskinen
2018-11-22 8:31 ` Peter Ujfalusi
2018-11-22 22:01 ` Aaro Koskinen
2018-11-23 11:45 ` Peter Ujfalusi
2018-11-24 0:17 ` Aaro Koskinen
2018-11-24 17:48 ` Russell King - ARM Linux
2018-11-24 19:06 ` Aaro Koskinen
2018-11-24 19:29 ` Russell King - ARM Linux
2018-11-22 10:29 ` Russell King - ARM Linux
2018-11-22 15:12 ` Russell King - ARM Linux
2018-11-22 22:24 ` Aaro Koskinen
2018-11-23 0:25 ` Russell King - ARM Linux
2018-11-23 1:23 ` Aaro Koskinen
2018-11-23 11:54 ` Peter Ujfalusi
2018-11-23 12:35 ` Peter Ujfalusi
2018-11-23 15:43 ` Russell King - ARM Linux
2018-11-23 16:16 ` Russell King - ARM Linux
2018-11-23 23:27 ` Russell King - ARM Linux
2018-11-23 18:52 ` Aaro Koskinen
2018-11-24 20:09 ` Russell King - ARM Linux
2018-11-25 1:07 ` Tony Lindgren
2018-11-25 1:11 ` Tony Lindgren
2018-11-25 11:11 ` Russell King - ARM Linux
2018-11-25 11:57 ` Russell King - ARM Linux
2018-11-25 16:58 ` Aaro Koskinen
2018-11-25 17:14 ` Tony Lindgren
2018-12-17 23:47 ` Aaro Koskinen
2018-12-18 15:55 ` Tony Lindgren
2018-12-17 19:16 ` Aaro Koskinen
2018-12-18 10:11 ` Peter Ujfalusi [this message]
2018-11-23 11:49 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36444432-a34c-826f-6efa-109921da69b7@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=tony@atomide.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).