From: "Ramuthevar, Vadivel MuruganX" <vadivel.muruganx.ramuthevar@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org,
devicetree@vger.kernel.org, miquel.raynal@bootlin.com,
richard@nod.at, vigneshr@ti.com, arnd@arndb.de,
brendanhiggins@google.com, tglx@linutronix.de,
boris.brezillon@collabora.com, anders.roxell@linaro.org,
masonccyang@mxic.com.tw, robh+dt@kernel.org,
linux-mips@vger.kernel.org, hauke.mehrtens@intel.com,
qi-ming.wu@intel.com, cheol.yong.kim@intel.com
Subject: Re: [PATCH v6 2/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC
Date: Thu, 14 May 2020 09:04:14 +0800 [thread overview]
Message-ID: <364cb1f3-1a66-20d3-f256-739ee9c915f0@linux.intel.com> (raw)
In-Reply-To: <20200513153532.GT185537@smile.fi.intel.com>
Hi Andy,
On 13/5/2020 11:35 pm, Andy Shevchenko wrote:
> On Wed, May 13, 2020 at 06:34:05PM +0300, Andy Shevchenko wrote:
>> On Wed, May 13, 2020 at 06:46:15PM +0800, Ramuthevar,Vadivel MuruganX wrote:
>
> ...
>
>>> +static int ebu_nand_remove(struct platform_device *pdev)
>>> +{
>>> + struct ebu_nand_controller *ebu_host = platform_get_drvdata(pdev);
>>> +
>>
>>> + if (ebu_host) {
>>
>> How it can be NULL here?
>>
>>> + mtd_device_unregister(nand_to_mtd(&ebu_host->chip));
>>> + nand_cleanup(&ebu_host->chip);
>>> + ebu_nand_disable(&ebu_host->chip);
>>> +
>
>>> + if (ebu_host->dma_rx || ebu_host->dma_tx)
>
> This is duplicate and thus redundant.
Let me check and update, Thanks!
Regards
Vadivel
>
>>> + ebu_dma_cleanup(ebu_host);
>>> +
>>> + clk_disable_unprepare(ebu_host->clk);
>>> + }
>>> +
>>> + return 0;
>>> +}
>
next prev parent reply other threads:[~2020-05-14 1:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 10:46 [PATCH v6 0/2] mtd: rawnand: Add NAND controller support on Intel LGM SoC Ramuthevar,Vadivel MuruganX
2020-05-13 10:46 ` [PATCH v6 1/2] dt-bindings: mtd: Add Nand Flash Controller support for " Ramuthevar,Vadivel MuruganX
2020-05-14 12:57 ` Rob Herring
2020-05-15 2:08 ` Ramuthevar, Vadivel MuruganX
2020-05-15 8:06 ` Ramuthevar, Vadivel MuruganX
2020-05-18 18:27 ` Rob Herring
2020-05-19 4:51 ` Ramuthevar, Vadivel MuruganX
2020-05-14 13:03 ` Rob Herring
2020-05-15 2:06 ` Ramuthevar, Vadivel MuruganX
2020-05-18 18:24 ` Rob Herring
2020-05-13 10:46 ` [PATCH v6 2/2] mtd: rawnand: Add NAND controller support on " Ramuthevar,Vadivel MuruganX
2020-05-13 15:34 ` Andy Shevchenko
2020-05-13 15:35 ` Andy Shevchenko
2020-05-14 1:04 ` Ramuthevar, Vadivel MuruganX [this message]
2020-05-14 1:02 ` Ramuthevar, Vadivel MuruganX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=364cb1f3-1a66-20d3-f256-739ee9c915f0@linux.intel.com \
--to=vadivel.muruganx.ramuthevar@linux.intel.com \
--cc=anders.roxell@linaro.org \
--cc=andriy.shevchenko@intel.com \
--cc=arnd@arndb.de \
--cc=boris.brezillon@collabora.com \
--cc=brendanhiggins@google.com \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=hauke.mehrtens@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=masonccyang@mxic.com.tw \
--cc=miquel.raynal@bootlin.com \
--cc=qi-ming.wu@intel.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).