From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031437AbbKDXJA (ORCPT ); Wed, 4 Nov 2015 18:09:00 -0500 Received: from mail-qk0-f170.google.com ([209.85.220.170]:33786 "EHLO mail-qk0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030385AbbKDXI7 (ORCPT ); Wed, 4 Nov 2015 18:08:59 -0500 From: Paul Moore To: Richard Guy Briggs Cc: linux-audit@redhat.com, linux-kernel@vger.kernel.org, v.rathor@gmail.com Subject: Re: [RFC PATCH 2/7] audit: include auditd's threads in audit_log_start() wait exception Date: Wed, 04 Nov 2015 18:08:57 -0500 Message-ID: <3659618.D3yUIFgye4@sifl> User-Agent: KMail/4.14.10 (Linux/4.2.3-gentoo; KDE/4.14.13; x86_64; ; ) In-Reply-To: <96c9dc3a967e093da911e7b1b222c190572db987.1445539473.git.rgb@redhat.com> References: <96c9dc3a967e093da911e7b1b222c190572db987.1445539473.git.rgb@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, October 22, 2015 02:53:15 PM Richard Guy Briggs wrote: > Should auditd spawn threads, allow all members of its thread group to > use the audit_backlog_limit reserves to bypass the queue limits too. > > Signed-off-by: Richard Guy Briggs > --- > kernel/audit.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Looks good, applied to audit#next-queue. > diff --git a/kernel/audit.c b/kernel/audit.c > index daefd81..3917aad 100644 > --- a/kernel/audit.c > +++ b/kernel/audit.c > @@ -1375,7 +1375,7 @@ struct audit_buffer *audit_log_start(struct > audit_context *ctx, gfp_t gfp_mask, return NULL; > > if (gfp_mask & __GFP_WAIT) { > - if (audit_pid && audit_pid == current->pid) > + if (audit_pid && audit_pid == current->tgid) > gfp_mask &= ~__GFP_WAIT; > else > reserve = 0; -- paul moore www.paul-moore.com