From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Eric Wong <e@80x24.org>, David Airlie <airlied@linux.ie>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>
Subject: Re: radeon vs radeonfb Mobility quirks (Thinkpad X32)
Date: Mon, 05 Nov 2018 10:14:57 +1100 [thread overview]
Message-ID: <365d8b24f1c6a28c32998924a95b6a2a74655526.camel@kernel.crashing.org> (raw)
In-Reply-To: <20181104042328.jzavn47y2wloprbs@untitled>
On Sun, 2018-11-04 at 04:23 +0000, Eric Wong wrote:
> Looking at drivers/video/fbdev/aty/radeon_pm.c, I notice it sets
> a D2 sleep mode for my X32:
>
> BUGFIX("IBM Thinkpad X31/X32",
> PCI_VENDOR_ID_IBM, 0x052f,
> radeon_pm_d2, NULL),
>
> Which I suspect is what allows "radeonfb" to work for me
>
> But I can't find the corresponding quirk in drivers/gpu/drm/radeon/,
> so I now believe a missing quirk is the cause of this problem
> with the "radeon" driver.
>
> I poked around but couldn't figure out what changes to make to
> the "radeon" driver to enable the corresponding, but I'm willing
> to test patches.
>
> Setting "dynpm" in /sys/**/power_method didn't seem to change
> things, either.
>
> Help greatly appreaciated. Thanks
>
>
> I've mainly been using the X32 as a server this decade so didn't
> use suspend/hibernate so I didn't investigate until recently
> (because my netbook died).
There's a whole pile of power management stuff for ancient laptops that
never quite made it from radeonfb to the radeon DRM driver... sadly it
also prevents sleep on old PowerBooks but I haven't had many complaints
so...
The code for D2 and D3 on those old things is reasonably self
contained, it shouldn't be that hard to move it over I suppose.
Cheers,
Ben.
next prev parent reply other threads:[~2018-11-04 23:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-04 4:23 radeon vs radeonfb Mobility quirks (Thinkpad X32) Eric Wong
2018-11-04 23:14 ` Benjamin Herrenschmidt [this message]
2018-11-08 0:03 ` Eric Wong
2018-11-08 2:19 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=365d8b24f1c6a28c32998924a95b6a2a74655526.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=David1.Zhou@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=b.zolnierkie@samsung.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=e@80x24.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).