Re: [PATCH v1] kbuild: Disable compile testing if HAVE_LEGACY_CLK enabled

From: Randy Dunlap <rdunlap@infradead.org>
To: Dmitry Osipenko <digetx@gmail.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Jonathan Hunter <jonathanh@nvidia.com>,
	Stephen Boyd <sboyd@kernel.org>, Tony Lindgren <tony@atomide.com>,
	Arnd Bergmann <arnd@arndb.de>, Paul Burton <paul.burton@mips.com>,
	John Crispin <john@phrozen.org>,
	"open list:BROADCOM NVRAM DRIVER" <linux-mips@vger.kernel.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	linux-m68k <linux-m68k@lists.linux-m68k.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-tegra <linux-tegra@vger.kernel.org>,
	linux-clk <linux-clk@vger.kernel.org>,
	"open list:TI ETHERNET SWITCH DRIVER (CPSW)" 
	<linux-omap@vger.kernel.org>
Subject: Re: [PATCH v1] kbuild: Disable compile testing if HAVE_LEGACY_CLK enabled
Date: Tue, 25 May 2021 17:39:55 -0700	[thread overview]
Message-ID: <3661fdba-ad32-5d16-7714-1ebc58caf435@infradead.org> (raw)
In-Reply-To: <2e5bb7c2-62d9-b1f7-7f35-2b379d3692d5@gmail.com>

On 5/25/21 2:29 PM, Dmitry Osipenko wrote:
> 25.05.2021 15:19, Geert Uytterhoeven пишет:
> ...
>>>> There 3 possible solutions:
>>>>
>>>> 1. Factor out COMMON_CLK from HAVE_LEGACY_CLK, if this is possible
>>>> 2. Build stubs universally, maybe using weak functions.
>>>
>>> I vote for this one - global stubs.
>>
>> Yep.
>>
>>> Or for a new one:
>>> 4. Disable COMPILE_TEST for specific platforms (mentioned in commit
>>> msg). Eventually could be like:
>>> config RALINK
>>>         depends !COMPILE_TEST || (COMPILE_TEST && COMMON_CLK)
>>
>> That's a neat idea!
>>
>> Of course there's a fifth option:
>>
>> 5. Convert legacy platforms to COMMON_CLK.
>>
>> Which is already happening for ARM EP93XX.
> 
> I'll try to take a closer look at alternative options, thank you for
> yours input.

Hi,

If you are messing around with HAVE_LEGACY_CLK and COMMON_CLK
and don't mind, please have a look at this report from
'kernel test robot':
  https://lore.kernel.org/lkml/202103162301.oomY9NwI-lkp@intel.com/

Maybe this one is more MIPS-specific. I dunno.
I tried to come up with a patch for it and failed.

I will be happy to built-test any patches that you come up with.

Maybe I have just looked at this too long...

thanks.
-- 
~Randy