linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] fixes for at91 devices
@ 2020-12-02  9:57 Claudiu Beznea
  2020-12-02  9:57 ` [PATCH 1/2] ARM: dts: at91: sam9x60ek: remove bypass property Claudiu Beznea
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Claudiu Beznea @ 2020-12-02  9:57 UTC (permalink / raw)
  To: robh+dt, nicolas.ferre, alexandre.belloni, ludovic.desroches
  Cc: sandeepsheriker.mallikarjun, devicetree, linux-arm-kernel,
	linux-kernel, Claudiu Beznea

Hi,

I added here 2 fixes for AT91 devices.

Thank you,
Claudiu Beznea

Claudiu Beznea (2):
  ARM: dts: at91: sam9x60ek: remove bypass property
  ARM: dts: at91: sama5d2: map securam as device

 arch/arm/boot/dts/at91-sam9x60ek.dts | 4 ----
 arch/arm/boot/dts/sama5d2.dtsi       | 1 +
 2 files changed, 1 insertion(+), 4 deletions(-)

-- 
2.7.4


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] ARM: dts: at91: sam9x60ek: remove bypass property
  2020-12-02  9:57 [PATCH 0/2] fixes for at91 devices Claudiu Beznea
@ 2020-12-02  9:57 ` Claudiu Beznea
  2020-12-02 10:27   ` Nicolas Ferre
  2020-12-02  9:57 ` [PATCH 2/2] ARM: dts: at91: sama5d2: map securam as device Claudiu Beznea
  2020-12-02 12:01 ` [PATCH 0/2] fixes for at91 devices Alexandre Belloni
  2 siblings, 1 reply; 6+ messages in thread
From: Claudiu Beznea @ 2020-12-02  9:57 UTC (permalink / raw)
  To: robh+dt, nicolas.ferre, alexandre.belloni, ludovic.desroches
  Cc: sandeepsheriker.mallikarjun, devicetree, linux-arm-kernel,
	linux-kernel, Claudiu Beznea, Marco Cardellini

atmel,osc-bypass property sets the bit 1 at main oscillator register.
On SAM9X60 this bit is not valid according to datasheet (chapter
28.16.9 PMC Clock Generator Main Oscillator Register).

Fixes: 720329e86a463 ("ARM: dts: at91: sam9x60: add device tree for soc and board")
Cc: Marco Cardellini <marco.cardellini@microchip.com>
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
 arch/arm/boot/dts/at91-sam9x60ek.dts | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm/boot/dts/at91-sam9x60ek.dts b/arch/arm/boot/dts/at91-sam9x60ek.dts
index 0e3b6147069f..73b6b1f89de9 100644
--- a/arch/arm/boot/dts/at91-sam9x60ek.dts
+++ b/arch/arm/boot/dts/at91-sam9x60ek.dts
@@ -578,10 +578,6 @@
 	};
 }; /* pinctrl */
 
-&pmc {
-	atmel,osc-bypass;
-};
-
 &pwm0 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_pwm0_0 &pinctrl_pwm0_1 &pinctrl_pwm0_2 &pinctrl_pwm0_3>;
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] ARM: dts: at91: sama5d2: map securam as device
  2020-12-02  9:57 [PATCH 0/2] fixes for at91 devices Claudiu Beznea
  2020-12-02  9:57 ` [PATCH 1/2] ARM: dts: at91: sam9x60ek: remove bypass property Claudiu Beznea
@ 2020-12-02  9:57 ` Claudiu Beznea
  2020-12-02 10:27   ` Nicolas Ferre
  2020-12-02 12:01 ` [PATCH 0/2] fixes for at91 devices Alexandre Belloni
  2 siblings, 1 reply; 6+ messages in thread
From: Claudiu Beznea @ 2020-12-02  9:57 UTC (permalink / raw)
  To: robh+dt, nicolas.ferre, alexandre.belloni, ludovic.desroches
  Cc: sandeepsheriker.mallikarjun, devicetree, linux-arm-kernel,
	linux-kernel, Claudiu Beznea

Due to strobe signal not being propagated from CPU to securam
the securam needs to be mapped as device or strongly ordered memory
to work properly. Otherwise, updating to one offset may affect
the adjacent locations in securam.

Fixes: d4ce5f44d4409 ("ARM: dts: at91: sama5d2: Add securam node")
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
 arch/arm/boot/dts/sama5d2.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
index 2ddc85dff8ce..6d399ac0385d 100644
--- a/arch/arm/boot/dts/sama5d2.dtsi
+++ b/arch/arm/boot/dts/sama5d2.dtsi
@@ -656,6 +656,7 @@
 				clocks = <&pmc PMC_TYPE_PERIPHERAL 51>;
 				#address-cells = <1>;
 				#size-cells = <1>;
+				no-memory-wc;
 				ranges = <0 0xf8044000 0x1420>;
 			};
 
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] ARM: dts: at91: sam9x60ek: remove bypass property
  2020-12-02  9:57 ` [PATCH 1/2] ARM: dts: at91: sam9x60ek: remove bypass property Claudiu Beznea
@ 2020-12-02 10:27   ` Nicolas Ferre
  0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Ferre @ 2020-12-02 10:27 UTC (permalink / raw)
  To: Claudiu Beznea, robh+dt, alexandre.belloni, ludovic.desroches
  Cc: sandeepsheriker.mallikarjun, devicetree, linux-arm-kernel,
	linux-kernel, Marco Cardellini

On 02/12/2020 at 10:57, Claudiu Beznea wrote:
> atmel,osc-bypass property sets the bit 1 at main oscillator register.
> On SAM9X60 this bit is not valid according to datasheet (chapter
> 28.16.9 PMC Clock Generator Main Oscillator Register).
> 
> Fixes: 720329e86a463 ("ARM: dts: at91: sam9x60: add device tree for soc and board")
> Cc: Marco Cardellini <marco.cardellini@microchip.com>
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
>   arch/arm/boot/dts/at91-sam9x60ek.dts | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/at91-sam9x60ek.dts b/arch/arm/boot/dts/at91-sam9x60ek.dts
> index 0e3b6147069f..73b6b1f89de9 100644
> --- a/arch/arm/boot/dts/at91-sam9x60ek.dts
> +++ b/arch/arm/boot/dts/at91-sam9x60ek.dts
> @@ -578,10 +578,6 @@
>   	};
>   }; /* pinctrl */
>   
> -&pmc {
> -	atmel,osc-bypass;
> -};
> -
>   &pwm0 {
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&pinctrl_pwm0_0 &pinctrl_pwm0_1 &pinctrl_pwm0_2 &pinctrl_pwm0_3>;
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] ARM: dts: at91: sama5d2: map securam as device
  2020-12-02  9:57 ` [PATCH 2/2] ARM: dts: at91: sama5d2: map securam as device Claudiu Beznea
@ 2020-12-02 10:27   ` Nicolas Ferre
  0 siblings, 0 replies; 6+ messages in thread
From: Nicolas Ferre @ 2020-12-02 10:27 UTC (permalink / raw)
  To: Claudiu Beznea, robh+dt, alexandre.belloni, ludovic.desroches
  Cc: sandeepsheriker.mallikarjun, devicetree, linux-arm-kernel, linux-kernel

On 02/12/2020 at 10:57, Claudiu Beznea wrote:
> Due to strobe signal not being propagated from CPU to securam
> the securam needs to be mapped as device or strongly ordered memory
> to work properly. Otherwise, updating to one offset may affect
> the adjacent locations in securam.
> 
> Fixes: d4ce5f44d4409 ("ARM: dts: at91: sama5d2: Add securam node")
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>

> ---
>   arch/arm/boot/dts/sama5d2.dtsi | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi
> index 2ddc85dff8ce..6d399ac0385d 100644
> --- a/arch/arm/boot/dts/sama5d2.dtsi
> +++ b/arch/arm/boot/dts/sama5d2.dtsi
> @@ -656,6 +656,7 @@
>   				clocks = <&pmc PMC_TYPE_PERIPHERAL 51>;
>   				#address-cells = <1>;
>   				#size-cells = <1>;
> +				no-memory-wc;
>   				ranges = <0 0xf8044000 0x1420>;
>   			};
>   
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 0/2] fixes for at91 devices
  2020-12-02  9:57 [PATCH 0/2] fixes for at91 devices Claudiu Beznea
  2020-12-02  9:57 ` [PATCH 1/2] ARM: dts: at91: sam9x60ek: remove bypass property Claudiu Beznea
  2020-12-02  9:57 ` [PATCH 2/2] ARM: dts: at91: sama5d2: map securam as device Claudiu Beznea
@ 2020-12-02 12:01 ` Alexandre Belloni
  2 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2020-12-02 12:01 UTC (permalink / raw)
  To: nicolas.ferre, robh+dt, ludovic.desroches, Claudiu Beznea
  Cc: Alexandre Belloni, devicetree, linux-arm-kernel, linux-kernel,
	sandeepsheriker.mallikarjun

On Wed, 2 Dec 2020 11:57:03 +0200, Claudiu Beznea wrote:
> I added here 2 fixes for AT91 devices.
> 
> Thank you,
> Claudiu Beznea
> 
> Claudiu Beznea (2):
>   ARM: dts: at91: sam9x60ek: remove bypass property
>   ARM: dts: at91: sama5d2: map securam as device
> 
> [...]

Applied, thanks!

[1/2] ARM: dts: at91: sam9x60ek: remove bypass property
      commit: d45879c1307f5b133c11e43e108bba459d17cee8
[2/2] ARM: dts: at91: sama5d2: map securam as device
      commit: b8af79e4b63c7e729ddbfe13eab20b1c97ffe442

Best regards,
-- 
Alexandre Belloni <alexandre.belloni@bootlin.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2020-12-02 12:02 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-02  9:57 [PATCH 0/2] fixes for at91 devices Claudiu Beznea
2020-12-02  9:57 ` [PATCH 1/2] ARM: dts: at91: sam9x60ek: remove bypass property Claudiu Beznea
2020-12-02 10:27   ` Nicolas Ferre
2020-12-02  9:57 ` [PATCH 2/2] ARM: dts: at91: sama5d2: map securam as device Claudiu Beznea
2020-12-02 10:27   ` Nicolas Ferre
2020-12-02 12:01 ` [PATCH 0/2] fixes for at91 devices Alexandre Belloni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).