From: Luis de Oliveira <luis.oliveira@synopsys.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Luis Oliveira <luis.oliveira@synopsys.com>
Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<joao.pinto@synopsys.com>, <festevam@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Hans Verkuil <hans.verkuil@cisco.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"Neil Armstrong" <narmstrong@baylibre.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Thierry Reding <treding@nvidia.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Todor Tomov <todor.tomov@linaro.org>
Subject: Re: [V3, 4/4] media: platform: dwc: Add MIPI CSI-2 controller driver
Date: Thu, 10 Jan 2019 17:00:07 +0000 [thread overview]
Message-ID: <367bf8de-a70b-145a-a69a-9edfa8c635b4@synopsys.com> (raw)
In-Reply-To: <1798955.5kaMj8jiTI@avalon>
Hi Laurent,
Sorry for taking so long to answer. I was stuck in other projects and lost track
of this.
My answers inline,
On 14-Nov-18 20:22, Laurent Pinchart wrote:
> Hi Luis,
>
> Thank you for the patch.
>
> On Friday, 19 October 2018 15:52:26 EET Luis Oliveira wrote:
>> Add the Synopsys MIPI CSI-2 controller driver. This
>> controller driver is divided in platform dependent functions
>> and core functions. It also includes a platform for future
>> DesignWare drivers.
>>
>> Signed-off-by: Luis Oliveira <lolivei@synopsys.com>
>> ---
>> Changelog
>> v2-V3
>> - exposed IPI settings to userspace
>
> Could you please explain why you need this and can't use standard APIs ?
> Custom sysfs attributes are needed, they need to be documented in
> Documentation/ABI/.
>
IPI - Image Pixel Interface enables to access direct video stream in our CSI-2
Host IP and needs to be configured to match the video source. I can't hard code
it. But maybe I can think of a way to configure it using the video configuration.
I will try do that in the next patchset.
>> - fixed headers
>>
>> MAINTAINERS | 11 +
>> drivers/media/platform/dwc/Kconfig | 30 +-
>> drivers/media/platform/dwc/Makefile | 2 +
>> drivers/media/platform/dwc/dw-csi-plat.c | 699 ++++++++++++++++++++++++++++
>> drivers/media/platform/dwc/dw-csi-plat.h | 77 ++++
>> drivers/media/platform/dwc/dw-mipi-csi.c | 494 ++++++++++++++++++++++
>> drivers/media/platform/dwc/dw-mipi-csi.h | 202 +++++++++
>> include/media/dwc/dw-mipi-csi-pltfrm.h | 102 +++++
>> 8 files changed, 1616 insertions(+), 1 deletion(-)
>> create mode 100644 drivers/media/platform/dwc/dw-csi-plat.c
>> create mode 100644 drivers/media/platform/dwc/dw-csi-plat.h
>> create mode 100644 drivers/media/platform/dwc/dw-mipi-csi.c
>> create mode 100644 drivers/media/platform/dwc/dw-mipi-csi.h
>> create mode 100644 include/media/dwc/dw-mipi-csi-pltfrm.h
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index da2e509..fd5f1fc 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -14032,6 +14032,16 @@ S: Maintained
>> F: drivers/dma/dwi-axi-dmac/
>> F: Documentation/devicetree/bindings/dma/snps,dw-axi-dmac.txt
>>
>> +SYNOPSYS DESIGNWARE MIPI CSI-2 HOST VIDEO PLATFORM
>> +M: Luis Oliveira <luis.oliveira@synopsys.com>
>> +L: linux-media@vger.kernel.org
>> +T: git git://linuxtv.org/media_tree.git
>> +S: Maintained
>> +F: drivers/media/platform/dwc
>> +F: include/media/dwc/dw-mipi-csi-pltfrm.h
>> +F: Documentation/devicetree/bindings/media/snps,dw-csi-plat.txt
>> +F: Documentation/devicetree/bindings/phy/snps,dphy-rx.txt
>
> These two lines belong to patches 1/4 and 3/4. Doesn't checkpatch.pl warn
> about this ? Now that I mentioned checkpatch.pl, I tried running it on this
> series, and it generates a fair number of warnings and errors. Could you
> please fix them ?
>
I did, but maybe - or probably - i did not fix them all. Sorry.
I am preparing a new patchset and I will make sure everything goes right this time.
>> +
>> SYNOPSYS DESIGNWARE DMAC DRIVER
>> M: Viresh Kumar <vireshk@kernel.org>
>> R: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> @@ -16217,3 +16227,4 @@ T: git
>> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git S: Buried
>> alive in reporters
>> F: *
>> F: */
>> +
>
> Stray new line.
>
Noted.
> [snip]
>
Thank you,
Luis
next prev parent reply other threads:[~2019-01-10 17:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 12:52 [V3, 0/4] platform: dwc: Add of DesignWare MIPI CSI-2 Host Luis Oliveira
2018-10-19 12:52 ` [V3, 1/4] Documentation: dt-bindings: phy: Document the Synopsys MIPI DPHY Rx bindings Luis Oliveira
2018-10-24 17:36 ` Rob Herring
2018-11-13 8:58 ` Luis Oliveira
2018-11-13 9:30 ` Luis de Oliveira
2018-11-14 20:08 ` Laurent Pinchart
2018-10-19 12:52 ` [V3, 2/4] media: platform: dwc: Add DW MIPI DPHY Rx platform Luis Oliveira
2019-01-07 11:58 ` Sakari Ailus
2019-01-08 9:17 ` Luis de Oliveira
2018-10-19 12:52 ` [V3, 3/4] Documentation: dt-bindings: media: Document bindings for DW MIPI CSI-2 Host Luis Oliveira
2018-10-24 17:40 ` Rob Herring
2018-11-13 10:00 ` Luis de Oliveira
2018-11-14 20:16 ` Laurent Pinchart
2018-10-24 17:41 ` Rob Herring
2018-11-13 10:00 ` Luis de Oliveira
2019-01-11 15:29 ` Eugen.Hristev
2018-10-19 12:52 ` [V3, 4/4] media: platform: dwc: Add MIPI CSI-2 controller driver Luis Oliveira
2018-11-14 20:22 ` Laurent Pinchart
2019-01-10 17:00 ` Luis de Oliveira [this message]
2018-12-10 12:39 ` Eugen.Hristev
2019-01-10 16:11 ` Luis de Oliveira
2019-01-09 13:07 ` Eugen.Hristev
2019-01-10 16:18 ` Luis de Oliveira
2019-01-11 7:25 ` Eugen.Hristev
2019-01-11 8:11 ` Luis de Oliveira
2019-01-11 9:49 ` Eugen.Hristev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=367bf8de-a70b-145a-a69a-9edfa8c635b4@synopsys.com \
--to=luis.oliveira@synopsys.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=festevam@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=joao.pinto@synopsys.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=mchehab@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=todor.tomov@linaro.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).