Re: [PATCH 6/9] nvme-apple: Add initial Apple SoC NVMe driver

From: Jens Axboe <axboe@fb.com>
To: Christoph Hellwig <hch@lst.de>, Hector Martin <marcan@marcan.st>
Cc: Sven Peter <sven@svenpeter.dev>, Keith Busch <kbusch@kernel.org>,
	Sagi Grimberg <sagi@grimberg.me>,
	Alyssa Rosenzweig <alyssa@rosenzweig.io>,
	Rob Herring <robh+dt@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	Marc Zyngier <maz@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 6/9] nvme-apple: Add initial Apple SoC NVMe driver
Date: Mon, 4 Apr 2022 12:29:08 -0600	[thread overview]
Message-ID: <367fe64f-0e57-b264-969a-c7cee6344f05@fb.com> (raw)
In-Reply-To: <20220404155924.GA9764@lst.de>

On 4/4/22 9:59 AM, Christoph Hellwig wrote:
> On Tue, Apr 05, 2022 at 12:57:33AM +0900, Hector Martin wrote:
>> The kernel hard limit is 100-character lines, not 80-character lines.
>> Maintainers for existing drivers are certainly free to stick to 80 chars
>> if they like it that way, but I don't see why we should still be
>> enforcing that for new code. See bdc48fa11e46.
> 
> Because 100 is completely utterly unreadable if is not for individual
> lines like strings, and that is actually how Linus stated it in
> CodingStyle.
> 
> Your code as-is is completely unreadable and will not go into
> drivers/nvme/ in that form.

Please reconsider how you phrase these objections. Saying the code is
"completely unreadable" because it's _1_ character over your hard limit
is just nonsense, and not a very productive way to deal with this.

-- 
Jens Axboe