From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425096AbcFHM1I (ORCPT ); Wed, 8 Jun 2016 08:27:08 -0400 Received: from gloria.sntech.de ([95.129.55.99]:56209 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751215AbcFHM1G (ORCPT ); Wed, 8 Jun 2016 08:27:06 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Tomeu Vizoso Cc: linux-kernel@vger.kernel.org, Shawn Lin , Javier Martinez Canillas , Mark Brown , linux-spi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] spi: rockchip: Signal unfinished DMA transfers Date: Wed, 08 Jun 2016 14:26:51 +0200 Message-ID: <3685265.1KrVuCJFto@diego> User-Agent: KMail/4.14.10 (Linux/4.4.0-1-amd64; KDE/4.14.14; x86_64; ; ) In-Reply-To: <1465371171-20810-1-git-send-email-tomeu.vizoso@collabora.com> References: <1465371171-20810-1-git-send-email-tomeu.vizoso@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 8. Juni 2016, 09:32:51 schrieb Tomeu Vizoso: > When using DMA, the transfer_one callback should return 1 because the > transfer hasn't finished yet. > > A previous commit changed the function to return 0 when the DMA channels > were correctly prepared. > > This manifested in Veyron boards with this message: > > [ 1.983605] cros-ec-spi spi0.0: EC failed to respond in time > > Signed-off-by: Tomeu Vizoso > Fixes: ea9849113343 ("spi: rockchip: check return value of > dmaengine_prep_slave_sg") > Cc: Shawn Lin > Cc: Heiko Stuebner > Cc: Javier Martinez Canillas looks like Mark already applied it, but nevertheless I was able to verify that this patch fixes the issue on my veyron jerry chromebook as well, so Tested-by: Heiko Stuebner