From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756940AbbFPIxj (ORCPT ); Tue, 16 Jun 2015 04:53:39 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:45998 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756595AbbFPIxP (ORCPT ); Tue, 16 Jun 2015 04:53:15 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Date: Tue, 16 Jun 2015 10:50:56 +0200 From: Stefan Agner To: Cory Tusar Cc: shawn.guo@linaro.org, kernel@pengutronix.de, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, andrew@lunn.ch Subject: Re: [PATCH] ARM: dts: vf610: Extend I2C support to all available buses. In-Reply-To: <1434327599-3739-1-git-send-email-cory.tusar@pid1solutions.com> References: <1434327599-3739-1-git-send-email-cory.tusar@pid1solutions.com> Message-ID: <36885aa1e7792b1b0bd072b1340cd5a0@agner.ch> User-Agent: Roundcube Webmail/1.1.2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015-06-15 02:19, Cory Tusar wrote: > This commit extends the existing Vybrid I2C support to cover buses i2c1, > i2c2, and i2c3. Based in (very) large part on an initial patch by > Stefan Agner that was just lacking a couple of DMA assignments. > > Signed-off-by: Cory Tusar Thx Cory for picking that up. So with that patch we use the second Mux of DMA0 the first time. Another option would have been to use the first Mux of DMA1, however I think its better to leave DMA1 for dedicated purposes or the secondary Cortex-M4 core... If a board needs different configuration, one would also have the option to overwrite the properties. Acked-by: Stefan Agner -- Stefan > --- > arch/arm/boot/dts/vfxxx.dtsi | 41 +++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 41 insertions(+) > > diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi > index 4aa3351..25f2615 100644 > --- a/arch/arm/boot/dts/vfxxx.dtsi > +++ b/arch/arm/boot/dts/vfxxx.dtsi > @@ -347,6 +347,20 @@ > status = "disabled"; > }; > > + i2c1: i2c@40067000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "fsl,vf610-i2c"; > + reg = <0x40067000 0x1000>; > + interrupts = <72 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clks VF610_CLK_I2C1>; > + clock-names = "ipg"; > + dmas = <&edma0 0 52>, > + <&edma0 0 53>; > + dma-names = "rx","tx"; > + status = "disabled"; > + }; > + > clks: ccm@4006b000 { > compatible = "fsl,vf610-ccm"; > reg = <0x4006b000 0x1000>; > @@ -520,6 +534,33 @@ > status = "disabled"; > }; > > + i2c2: i2c@400e6000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "fsl,vf610-i2c"; > + reg = <0x400e6000 0x1000>; > + interrupts = <73 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clks VF610_CLK_I2C2>; > + clock-names = "ipg"; > + dmas = <&edma0 1 36>, > + <&edma0 1 37>; > + dma-names = "rx","tx"; > + status = "disabled"; > + }; > + > + i2c3: i2c@400e7000 { > + #address-cells = <1>; > + #size-cells = <0>; > + compatible = "fsl,vf610-i2c"; > + reg = <0x400e7000 0x1000>; > + interrupts = <74 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clks VF610_CLK_I2C3>; > + clock-names = "ipg"; > + dmas = <&edma0 1 38>, > + <&edma0 1 39>; > + dma-names = "rx","tx"; > + status = "disabled"; > + }; > }; > }; > };