From: Heiko Stuebner <heiko@sntech.de>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Joerg Roedel <joro@8bytes.org>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Simon Xue <xxm@rock-chips.com>,
Daniel Kurtz <djkurtz@chromium.org>,
Jeffy Chen <jeffy.chen@rock-chips.com>,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 2/9] iommu: rockchip: make it explicitly non-modular
Date: Tue, 27 Nov 2018 00:37:07 +0100 [thread overview]
Message-ID: <3696101.6o5idU3W3V@phil> (raw)
In-Reply-To: <1543271498-28966-3-git-send-email-paul.gortmaker@windriver.com>
Am Montag, 26. November 2018, 23:31:31 CET schrieb Paul Gortmaker:
> The Kconfig currently controlling compilation of this code is:
>
> drivers/iommu/Kconfig:config ROCKCHIP_IOMMU
> drivers/iommu/Kconfig: bool "Rockchip IOMMU Support"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> The bind/unbind/remove was already explicitly disabled in commit
> 98b72b94def9 ("iommu/rockchip: Prohibit unbind and remove").
>
> Lets remove the remaining traces of modular infrastructure, so that
> when reading the driver there is no doubt it is builtin-only.
>
> Since module_init was not in use by this code, the init ordering
> remains unchanged with this commit.
>
> Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code.
>
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
>
> Cc: Joerg Roedel <joro@8bytes.org>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: Simon Xue <xxm@rock-chips.com>
> Cc: Daniel Kurtz <djkurtz@chromium.org>
> Cc: Jeffy Chen <jeffy.chen@rock-chips.com>
> Cc: iommu@lists.linux-foundation.org
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-rockchip@lists.infradead.org
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
next prev parent reply other threads:[~2018-11-26 23:37 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 22:31 [PATCH 0/9] iommu: clean up/remove modular stuff from non-modules Paul Gortmaker
2018-11-26 22:31 ` [PATCH 1/9] iommu: audit and remove any unnecessary uses of module.h Paul Gortmaker
2018-11-26 22:31 ` [PATCH 2/9] iommu: rockchip: make it explicitly non-modular Paul Gortmaker
2018-11-26 23:37 ` Heiko Stuebner [this message]
2018-11-26 22:31 ` [PATCH 3/9] iommu: msm_iommu: " Paul Gortmaker
2018-11-26 22:31 ` [PATCH 4/9] iommu: mtk_iommu: " Paul Gortmaker
2018-11-27 1:25 ` Honghui Zhang
2018-11-26 22:31 ` [PATCH 5/9] iommu: ipmmu-vmsa: " Paul Gortmaker
2018-11-28 12:50 ` Robin Murphy
2018-11-28 15:32 ` Paul Gortmaker
2018-11-28 17:22 ` Laurent Pinchart
2018-11-28 22:10 ` Paul Gortmaker
2018-11-26 22:31 ` [PATCH 6/9] iommu: qcom_iommu: " Paul Gortmaker
2018-11-26 22:31 ` [PATCH 7/9] iommu: tegra-gart: " Paul Gortmaker
2018-11-27 14:18 ` Thierry Reding
2018-11-26 22:31 ` [PATCH 8/9] iommu: arm-smmu: " Paul Gortmaker
2018-11-28 12:42 ` Robin Murphy
2018-11-28 15:24 ` Paul Gortmaker
2018-11-28 17:28 ` Robin Murphy
2018-11-26 22:31 ` [PATCH 9/9] iommu: arm-smmu-v3: " Paul Gortmaker
2018-11-28 12:44 ` Robin Murphy
2018-11-27 10:11 ` [PATCH 0/9] iommu: clean up/remove modular stuff from non-modules Joerg Roedel
2018-11-27 14:39 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3696101.6o5idU3W3V@phil \
--to=heiko@sntech.de \
--cc=djkurtz@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jeffy.chen@rock-chips.com \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=paul.gortmaker@windriver.com \
--cc=xxm@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).