From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752565AbcBVH72 (ORCPT ); Mon, 22 Feb 2016 02:59:28 -0500 Received: from mga03.intel.com ([134.134.136.65]:34741 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750877AbcBVH71 convert rfc822-to-8bit (ORCPT ); Mon, 22 Feb 2016 02:59:27 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,483,1449561600"; d="scan'208";a="908420178" From: "Chen, Yu C" To: "Zheng, Lv" , "linux-acpi@vger.kernel.org" CC: "linux-kernel@vger.kernel.org" , "rjw@rjwysocki.net" , "lenb@kernel.org" , "matthew.garrett@nebula.com" , "andy.shevchenko@gmail.com" Subject: RE: [PATCH][v3] ACPI: Do not report _OSI("Darwin") when acpi_osi=!Darwin provided Thread-Topic: [PATCH][v3] ACPI: Do not report _OSI("Darwin") when acpi_osi=!Darwin provided Thread-Index: AQHRXVoH+ieci5mwWEGGILwKH031e583TGkAgACGY6A= Date: Mon, 22 Feb 2016 07:59:12 +0000 Message-ID: <36DF59CE26D8EE47B0655C516E9CE640286C6882@shsmsx102.ccr.corp.intel.com> References: <1454377278-3398-1-git-send-email-yu.c.chen@intel.com> <1AE640813FDE7649BE1B193DEA596E883BB4DAB4@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <1AE640813FDE7649BE1B193DEA596E883BB4DAB4@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDU4MTdiMDAtZDZjYy00ZmFlLTkzMDEtODg0ODdlMmVlYmRlIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImtYaFZCdVdXK2VKS2QxdTBTMFMyK1ZwMnUrUzRYMHQrc21DOGlRZEVCWFU9In0= x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: Zheng, Lv > Sent: Monday, February 22, 2016 3:57 PM > To: Chen, Yu C; linux-acpi@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; rjw@rjwysocki.net; lenb@kernel.org; > matthew.garrett@nebula.com; andy.shevchenko@gmail.com; Chen, Yu C > Subject: RE: [PATCH][v3] ACPI: Do not report _OSI("Darwin") when > acpi_osi=!Darwin provided > > Hi, Yu > > > From: linux-acpi-owner@vger.kernel.org [mailto:linux-acpi- > > owner@vger.kernel.org] On Behalf Of Chen Yu > > Subject: [PATCH][v3] ACPI: Do not report _OSI("Darwin") when > > acpi_osi=!Darwin provided > > > > Commit 7bc5a2bad0b8 ("ACPI: Support _OSI("Darwin") correctly") always > > reports positive value when Apple hardware queries _OSI("Darwin"). > > But sometimes the users might want to tell the hardware they don't > > need the Darwin feature, for example, users may leverage the hardware > > to power off the Thunderbolt, by appending acpi_osi=!Darwin in command > > line, thus Apple hardware regards it as an incompatible OS X system, > > hence turns off the Thunderbolt. > [Lv Zheng] > Both this patch and the original commit that is from Matthew look wrong to > me. > IMO, the feature should be done with an entirely different approach. > Without test, I'm not sure if my comment is helpful for you. > So could you let me take over to fix this issue? > Yes, sure, thanks. yu