From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S941050AbdDTEnp convert rfc822-to-8bit (ORCPT ); Thu, 20 Apr 2017 00:43:45 -0400 Received: from mailout3.w2.samsung.com ([211.189.100.13]:46690 "EHLO usmailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S941035AbdDTEnm (ORCPT ); Thu, 20 Apr 2017 00:43:42 -0400 X-Greylist: delayed 601 seconds by postgrey-1.27 at vger.kernel.org; Thu, 20 Apr 2017 00:43:41 EDT X-AuditID: cbfec373-f79766d000001fd4-6d-58f83a22bd86 From: Judy Brock To: Andy Lutomirski , Jens Axboe Cc: Sagi Grimberg , "linux-kernel@vger.kernel.org" , linux-nvme , Keith Busch , Kai-Heng Feng , Christoph Hellwig , Niranjan Sivakumar Subject: RE: [PATCH 4/5] nvme: Adjust the Samsung APST quirk Thread-topic: [PATCH 4/5] nvme: Adjust the Samsung APST quirk Thread-index: AQHSuYKsRKZBnX16DkyS7kD2E0iYVKHOCLwAgAAMRgD//4uusA== Date: Thu, 20 Apr 2017 04:33:34 +0000 Message-id: <36E8D38D6B771A4BBDB1C0D800158A51879547C5@SSIEXCH-MB3.ssi.samsung.com> In-reply-to: Accept-Language: en-US Content-language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: X-Originating-IP: [105.128.248.60] Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 8BIT MIME-version: 1.0 X-CFilter-Loop: Reflected X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKKsWRmVeSWpSXmKPExsWy7djXc7pKVj8iDD6/V7dYfbefzWLl6qNM Fv+6l7FZ3Dv6hcni8q45bBbzlz1ltzi/ay2rxc+Fb9gs1r1+z+LA6TGroZfNY9W5bnaP8/c2 sngs3vOSyePy2VKPTas62Tw2L6n32H2zgc3j8ya5AM4oLpuU1JzMstQifbsErowHl8+yFsyR qzhwYDNzA+MCiS5GTg4JAROJl+c3sEDYYhIX7q1n62Lk4hASWM4ocfzCZ3YIp41JYuXvF2ww HWePLGWGSKxglPhy+yNYAqxq2VMhiMRpRon2qUvBEmwCmhJHzzSB7RARcJboOtnJAlLELLCJ SaJhZQ9YkbCAjcSGX8vZIYpsJR5+2cQIYTtJ7D64lxnEZhFQldh0+B9QPQcHr0CIxKPtniBh ToFgiSvL+sBaGYF++H5qDROIzSwgLtHcehPqN0GJRbP3MMP8+W/XQ6hvlCTmzmiDqteROHts HSOErS3x5N0FVhCbF6j3x+R7UHMkJQ6uuAF2v4TAUg6JY8cPs4PcIyEgK7HpANR8F4nva08y QtjCEq+Ob2GHsGUkjj9czwphH2OUuD7LeAKj+iwkp85CcsYsJGfMQnLGAkaWVYwipcXFuemp xaZ6xYm5xaV56XrJ+bmbGIGJ6/S/w8U7GF9ssDrEKMDBqMTDG5H2PUKINbGsuDL3EKMEB7OS CG+w+Y8IId6UxMqq1KL8+KLSnNTiQ4zSHCxK4rzPdl2LEBJITyxJzU5NLUgtgskycXBKNTCq 89z6q1pZ/XadeO4Cq98CR4/LJVw6FbHBYLqpatbNI01h58N0l01WE57+8JDeNNvPXaodGe0S bzPvBpRGbokr3XT76xsn0VWXZr863CYmuuNqwjZmkT25/4S+xwT1TTyi5aT/ga3N8/h68ZtV fIfjrBv7mQslVT5ND5BdPIVrG/exm7+v1rxTYinOSDTUYi4qTgQAW4tSa1gDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrDKsWRmVeSWpSXmKPExsVy+t9hX11Fqx8RBq3btC1W3+1ns1i5+iiT xb/uZWwW945+YbK4vGsOm8X8ZU/ZLc7vWstq8XPhGzaLda/fszhwesxq6GXzWHWum93j/L2N LB6L97xk8rh8ttRj06pONo/NS+o9dt9sYPP4vEkugDPKzSYjNTEltUghNS85PyUzL91WKTTE TddCSSEvMTfVVilC1zckSEmhLDGnFMgzMkADDs4B7sFK+nYJbhkPLp9lLZgjV3HgwGbmBsYF El2MnBwSAiYSZ48sZYawxSQu3FvP1sXIxSEksIxRovfsYyYIp4NJYsK+y+wQzmlGibdTHrKB tLAJaEocPdPEAmKLCDhLdJ3sZAEpYhbYwiRxfNVJdpCEsICNxIZfy9khimwlHn7ZxAhhO0ns PrgXbDeLgKrEpsP/wIbyCoRIHDjyF+qOV4wSJz/vB9vAKRAssX33c7AiRqBjv59awwRiMwuI SzS33mSBeEJAYsme81APiUq8fPyPFcJWkpg7ow2qXkti/c7jULa2xJN3F1ghFgtK/Jh8D2qO pMTBFTdYJjBKzEKyYhaS9llI2mchaV/AyLKKUaS0uDg3vaLYSK84Mbe4NC9dLzk/dxMjJOVU 72C8+9XmEKMAB6MSD29E2vcIIdbEsuLK3EOMEhzMSiK8weY/IoR4UxIrq1KL8uOLSnNSiw8x mgJDaSKzlGhyPjAd5pXEG5qYG5iaGBpZmhqamSqJ8/qsXxYuJJCeWJKanZpakFoE08fEwSnV wOhuc1R3kYlZ5vWi+YU7vTXkGdmiQiWbZx55ZZbYEMZf0fUmeLV2llh84ReGuknKJ5jfSuSI nGg6OOmZxsbwm98YDC9u1DVx2eHH+Y1JW+OLeuMjHg4H5QnCvQxbNHsPLXn669zTC86ml6Yc 5N02SchaMbOlrkbuxAWOw+uktAr+q1j3G/+fpsRSnJFoqMVcVJwIAH98ejtPAwAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170420043337uscas1p1614437f255a643cdb08e44c4fd43424f X-Msg-Generator: CA X-Sender-IP: 203.254.195.123 X-Local-Sender: =?UTF-8?B?SnVkeSBCcm9jaxtBbWVyaWNhIE9mZmljZShEUyktUiZELU1T?= =?UTF-8?B?TCAtIEVudGVycHJpc2UgUHJvZHVjdCBEZXZlbG9wbWVudCAtIFImRBvsgrw=?= =?UTF-8?B?7ISx7KCE7J6QG0VuZ2luZWVyIFN0YWZm?= X-Global-Sender: =?UTF-8?B?SnVkeSBCcm9jaxtBbWVyaWNhIE9mZmljZShEUyktUiZELU1T?= =?UTF-8?B?TCAtIEVudGVycHJpc2UgUHJvZHVjdCBEZXZlbG9wbWVudCAtIFImRBtTYW1z?= =?UTF-8?B?dW5nwqBFbGVjdHJvbmljcxtFbmdpbmVlciBTdGFmZg==?= X-Sender-Code: =?UTF-8?B?QzEwG05BSFEbQzEwQUQwNkFCMDYwMjg2?= CMS-TYPE: 301P X-HopCount: 7 X-CMS-RootMailID: 20170420043337uscas1p1614437f255a643cdb08e44c4fd43424f X-RootMTR: 20170420043337uscas1p1614437f255a643cdb08e44c4fd43424f References: <20170420030711.GB23085@kernel.dk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [Jens] Do we know for a fact that it only happens on those systems, and isn't > purely specific to the device? [Andy] I have decent evidence. All of the reports are from XPS 15 9550 or Precision 5510, and Dell confirmed that they're basically the same machine and run literally the same BIOS. The answer as per the above as far as we know is "yes". > > At this point in time, I'd be much more comfortable completely > disabling APST on Samsung, period. > 1) Why? The answer to the question above was "Yes". This has been reported exclusively on the two Dell models with that exact same BIOS. Additionally, there are reports of the device acting fine on other systems so it is not purely specific to the device. We request that the quirk should be only on the affected Dell machines - there is no reason to completely disable APST on Samsung. 2) Samsung shared in the more private thread that we are seeing excessive recovery attempts on the PCIe bus - no PCIe TLPs seen, just ordered sets. This looks like a signal integrity problem to us on the Dell side. We shared excerpt of PCIe trace on the offline thread. 3) We also shared a more extensive report with Dell today. We've asked them to look into it. 4) There was at least one report of same symptom on a Toshiba device and Lenovo system that seemed to also disappear by avoiding PS4. So it seems it would be best to continue to try to get to the bottom of the problem (root cause) and quirk judiciously in the meantime. Thanks, Judy -----Original Message----- From: Linux-nvme [mailto:linux-nvme-bounces@lists.infradead.org] On Behalf Of Andy Lutomirski Sent: Wednesday, April 19, 2017 8:51 PM To: Jens Axboe Cc: Sagi Grimberg; linux-kernel@vger.kernel.org; linux-nvme; Keith Busch; Kai-Heng Feng; Andy Lutomirski; Christoph Hellwig; Niranjan Sivakumar Subject: Re: [PATCH 4/5] nvme: Adjust the Samsung APST quirk On Wed, Apr 19, 2017 at 8:07 PM, Jens Axboe wrote: > On Wed, Apr 19 2017, Andy Lutomirski wrote: >> I got a couple more reports: the Samsung APST issues appears to >> affect multiple 950-series devices in Dell XPS 15 9550 and Precision >> 5510 laptops. Change the quirk: rather than blacklisting the >> firmware on the first problematic SSD that was reported, disable APST >> on all 144d:a802 devices if they're installed in the two affected >> Dell models. While we're at it, disable only the deepest sleep state >> instead of all of them -- the reporters say that this is sufficient >> to fix the problem. >> >> (I have a device that appears to be entirely identical to one of the >> affected devices, but I have a different Dell laptop, so it's not the >> case that all Samsung devices with firmware BXW75D0Q are broken under >> all circumstances.) >> >> Samsung engineers have an affected system, and hopefully they'll give >> us a better workaround some time soon. In the mean time, this should >> minimize regressions. > > Do we know for a fact that it only happens on those systems, and isn't > purely specific to the device? I have decent evidence. All of the reports are from XPS 15 9550 or Precision 5510, and Dell confirmed that they're basically the same machine and run literally the same BIOS. One of these reports is from a device with exactly the same model and firmware as my SSD, and mine is fine. (I have a different laptop.) > > At this point in time, I'd be much more comfortable completely > disabling APST on Samsung, period. > I'd be fine with doing that for 4.11 and then doing this for 4.12-rc1. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme