From: Stanimir Varbanov <stanimir.varbanov@linaro.org>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Nicolas Dufresne <nicolas@ndufresne.ca>,
Vikash Garodia <vgarodia@codeaurora.org>
Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org, acourbot@chromium.org
Subject: Re: [PATCH] venus: vdec: fix decoded data size
Date: Mon, 17 Sep 2018 17:30:30 +0300 [thread overview]
Message-ID: <36b42952-982c-9048-77fb-72ca45cc7476@linaro.org> (raw)
In-Reply-To: <33e8d8e3-138e-0031-5b75-4bef114ac75e@xs4all.nl>
Hi Hans,
On 09/17/2018 01:00 PM, Hans Verkuil wrote:
> On 07/18/2018 04:37 PM, Stanimir Varbanov wrote:
>> Hi,
>>
>> On 07/18/2018 04:26 PM, Nicolas Dufresne wrote:
>>> Le mercredi 18 juillet 2018 à 14:31 +0300, Stanimir Varbanov a écrit :
>>>> Hi Vikash,
>>>>
>>>> On 07/02/2018 10:44 AM, Vikash Garodia wrote:
>>>>> Exisiting code returns the max of the decoded
>>>>> size and buffer size. It turns out that buffer
>>>>> size is always greater due to hardware alignment
>>>>> requirement. As a result, payload size given to
>>>>> client is incorrect. This change ensures that
>>>>> the bytesused is assigned to actual payload size.
>>>>>
>>>>> Change-Id: Ie6f3429c0cb23f682544748d181fa4fa63ca2e28
>>>>> Signed-off-by: Vikash Garodia <vgarodia@codeaurora.org>
>>>>> ---
>>>>> drivers/media/platform/qcom/venus/vdec.c | 2 +-
>>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/drivers/media/platform/qcom/venus/vdec.c
>>>>> b/drivers/media/platform/qcom/venus/vdec.c
>>>>> index d079aeb..ada1d2f 100644
>>>>> --- a/drivers/media/platform/qcom/venus/vdec.c
>>>>> +++ b/drivers/media/platform/qcom/venus/vdec.c
>>>>> @@ -890,7 +890,7 @@ static void vdec_buf_done(struct venus_inst
>>>>> *inst, unsigned int buf_type,
>>>>>
>>>>> vb = &vbuf->vb2_buf;
>>>>> vb->planes[0].bytesused =
>>>>> - max_t(unsigned int, opb_sz, bytesused);
>>>>> + min_t(unsigned int, opb_sz, bytesused);
>>>>
>>>> Most probably my intension was to avoid bytesused == 0, but that is
>>>> allowed from v4l2 driver -> userspace direction
>>>
>>> It remains bad practice since it was used by decoders to indicate the
>>> last buffer. Some userspace (some GStreamer versions) will stop working
>>> if you start returning 0.
>>
>> I think it is legal v4l2 driver to return bytesused = 0 when userspace
>> issues streamoff on both queues before EOS, no? Simply because the
>> capture buffers are empty.
>>
>
> Going through some of the older pending patches I found this one:
>
> So is this patch right or wrong?
I'm not sure either, let's not applying it for now (if Nicolas is right
this will break gstreamer plugin).
--
regards,
Stan
next prev parent reply other threads:[~2018-09-17 14:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 7:44 [PATCH] venus: vdec: fix decoded data size Vikash Garodia
2018-07-02 8:51 ` Alexandre Courbot
2018-07-06 15:12 ` Stanimir Varbanov
2018-07-06 17:09 ` Alexandre Courbot
2018-07-07 12:26 ` Stanimir Varbanov
2018-07-18 11:31 ` Stanimir Varbanov
2018-07-18 13:26 ` Nicolas Dufresne
2018-07-18 14:37 ` Stanimir Varbanov
2018-09-17 10:00 ` Hans Verkuil
2018-09-17 14:30 ` Stanimir Varbanov [this message]
2018-09-17 14:32 ` Hans Verkuil
2018-09-19 10:32 ` Alexandre Courbot
2018-09-19 15:02 ` Stanimir Varbanov
2018-09-19 15:53 ` Nicolas Dufresne
2018-09-20 3:02 ` Tomasz Figa
2018-09-25 9:41 ` Stanimir Varbanov
2018-10-02 7:38 ` Stanimir Varbanov
2018-10-03 11:30 Vikash Garodia
2018-10-03 12:36 ` Stanimir Varbanov
2018-10-05 15:26 ` Stanimir Varbanov
2018-10-08 11:19 ` Vikash Garodia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36b42952-982c-9048-77fb-72ca45cc7476@linaro.org \
--to=stanimir.varbanov@linaro.org \
--cc=acourbot@chromium.org \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=vgarodia@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).