From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932144AbZDHMXU (ORCPT ); Wed, 8 Apr 2009 08:23:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759941AbZDHMW4 (ORCPT ); Wed, 8 Apr 2009 08:22:56 -0400 Received: from fk-out-0910.google.com ([209.85.128.185]:32219 "EHLO fk-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752969AbZDHMWy convert rfc822-to-8bit (ORCPT ); Wed, 8 Apr 2009 08:22:54 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=qTm6tK7y44JFWbed92UMpCZ8zlVvdLkQlfN2siys4/6g1wnFinRwlmAjm7Yxy4ERhq +siZO4JXE705Jbw97NQ0Ghf8a7iGJjFry61zDwFBFSckQOBpl7WQQARoyGUkYe6mCt8y cQVjT6Vv/cXUOjBEtLKb4vNcVh/NAyrEk1PSU= MIME-Version: 1.0 In-Reply-To: <1239189748-11703-36-git-send-email-jwjstone@fastmail.fm> References: <1239189748-11703-1-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-28-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-29-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-30-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-31-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-32-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-33-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-34-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-35-git-send-email-jwjstone@fastmail.fm> <1239189748-11703-36-git-send-email-jwjstone@fastmail.fm> Date: Wed, 8 Apr 2009 14:22:52 +0200 Message-ID: <36ca99e90904080522o4813667fx535e02179b1f3688@mail.gmail.com> Subject: Re: [PATCH 35/56] ntfs: Remove void casts From: Bert Wesarg To: Jack Stone Cc: linux-kernel@vger.kernel.org, jeff@garzik.org, kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 8, 2009 at 13:22, Jack Stone wrote: > Remove uneeded void casts > > Signed-Off-By: Jack Stone > --- >  fs/ntfs/compress.c |    2 +- >  fs/ntfs/dir.c      |    8 ++++---- >  fs/ntfs/index.c    |    2 +- >  fs/ntfs/logfile.c  |    2 +- >  fs/ntfs/mft.c      |    4 ++-- >  fs/ntfs/super.c    |    8 ++++---- >  fs/ntfs/usnjrnl.c  |    2 +- >  7 files changed, 14 insertions(+), 14 deletions(-) > > diff --git a/fs/ntfs/compress.c b/fs/ntfs/compress.c > index 9669541..12297ee 100644 > --- a/fs/ntfs/compress.c > +++ b/fs/ntfs/compress.c > @@ -280,7 +280,7 @@ return_error: >        } > >        /* We have a valid destination page. Setup the destination pointers. */ > -       dp_addr = (u8*)page_address(dp) + do_sb_start; > +       dp_addr = page_address(dp) + do_sb_start; Pointer arithmetic. > >        /* Now, we are ready to process the current sub-block (sb). */ >        if (!(le16_to_cpup((le16*)cb) & NTFS_SB_IS_COMPRESSED)) { > diff --git a/fs/ntfs/logfile.c b/fs/ntfs/logfile.c > index d7932e9..b6be7c4 100644 > --- a/fs/ntfs/logfile.c > +++ b/fs/ntfs/logfile.c > @@ -549,7 +549,7 @@ bool ntfs_check_logfile(struct inode *log_vi, RESTART_PAGE_HEADER **rp) >                                goto err_out; >                        } >                } > -               kaddr = (u8*)page_address(page) + (pos & ~PAGE_CACHE_MASK); > +               kaddr = page_address(page) + (pos & ~PAGE_CACHE_MASK); Pointer arithmetic. >                /* >                 * A non-empty block means the logfile is not empty while an >                 * empty block after a non-empty block has been encountered > diff --git a/fs/ntfs/mft.c b/fs/ntfs/mft.c > index 23bf684..552f91b 100644 > --- a/fs/ntfs/mft.c > +++ b/fs/ntfs/mft.c > @@ -1196,7 +1196,7 @@ static int ntfs_mft_bitmap_find_and_alloc_free_rec_nolock(ntfs_volume *vol, >                                                "bitmap, aborting."); >                                return PTR_ERR(page); >                        } > -                       buf = (u8*)page_address(page) + page_ofs; > +                       buf = page_address(page) + page_ofs; Pointer arithmetic. >                        bit = data_pos & 7; >                        data_pos &= ~7ull; >                        ntfs_debug("Before inner for loop: size 0x%x, " > @@ -1334,7 +1334,7 @@ static int ntfs_mft_bitmap_extend_allocation_nolock(ntfs_volume *vol) >                ntfs_error(vol->sb, "Failed to read from lcn bitmap."); >                return PTR_ERR(page); >        } > -       b = (u8*)page_address(page) + (ll & ~PAGE_CACHE_MASK); > +       b = page_address(page) + (ll & ~PAGE_CACHE_MASK); Pointer arithmetic. >        tb = 1 << (lcn & 7ull); >        down_write(&vol->lcnbmp_lock); >        if (*b != 0xff && !(*b & tb)) { > -- Bert