From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: xinlei.lee@mediatek.com, thierry.reding@gmail.com,
u.kleine-koenig@pengutronix.de, lee.jones@linaro.org,
robh+dt@kernel.org, matthias.bgg@gmail.com,
jitao.shi@mediatek.com
Cc: allen-kh.cheng@mediatek.com, linux-pwm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com,
Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
Subject: Re: [v2,1/4] dt-bindings: pwm: Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format
Date: Wed, 16 Feb 2022 11:22:50 +0100 [thread overview]
Message-ID: <370739d4-2da6-b620-ec79-adf8d00c8c33@canonical.com> (raw)
In-Reply-To: <1645003971-16908-2-git-send-email-xinlei.lee@mediatek.com>
On 16/02/2022 10:32, xinlei.lee@mediatek.com wrote:
> From: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
>
> Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format as suggested by maintainer
>
> Signed-off-by: Xinlei Lee <xinlei.lee@mediatek.corp-partner.google.com>
> ---
> .../bindings/pwm/mediatek,pwm-disp.yaml | 71 +++++++++++++++++++
> .../devicetree/bindings/pwm/pwm-mtk-disp.txt | 44 ------------
> 2 files changed, 71 insertions(+), 44 deletions(-)
> create mode 100755 Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-mtk-disp.txt
>
> diff --git a/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> new file mode 100755
> index 000000000000..edf2a2e9ea72
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pwm/mediatek,pwm-disp.yaml
> @@ -0,0 +1,71 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pwm/mediatek,pwm-disp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek PWM Controller Device Tree Bindings
This is a Display PWM, not a generic PWM.
> +
> +maintainers:
> + - Jitao Shi <jitao.shi@mediatek.com>
> + - Xinlei Lee <xinlei.lee@mediatek.com>
> +
My comment about pwm schema was ignored.
Please include pwm.yaml.
> +properties:
> + compatible:
> + enum:
> + - mediatek,mt2701-disp-pwm
> + - mediatek,mt6595-disp-pwm
> + - mediatek,mt8173-disp-pwm
> + - mediatek,mt8183-disp-pwm
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> + "#pwm-cells":
> + description:
> + Number of cells in a PWM specifier.
Need a const. Description can be skipped, it's obvious.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-02-16 10:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 9:32 [v2,0/4] Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format xinlei.lee
2022-02-16 9:32 ` [v2,1/4] dt-bindings: pwm: " xinlei.lee
2022-02-16 10:22 ` Krzysztof Kozlowski [this message]
2022-02-16 22:51 ` Rob Herring
[not found] ` <0f8c014c077d0fc75c8552e457482d9daf68d73b.camel@mediatek.com>
2022-02-24 20:49 ` Rob Herring
2022-02-25 6:24 ` [v2, 1/4] dt-bindings: pwm: Convert pwm-mtk-disp.txt to mediatek, pwm-disp.yaml format Chen-Yu Tsai
[not found] ` <918bfe38f716c2e1ca411ae42a5a9ab0bf810692.camel@mediatek.com>
2022-02-25 7:22 ` Chen-Yu Tsai
2022-02-16 9:32 ` [v2,2/4] dt-bindings: pwm: Add compatible for MediaTek MT8192 xinlei.lee
2022-02-16 10:24 ` Krzysztof Kozlowski
2022-02-16 9:32 ` [v2,3/4] dt-bindings: pwm: Add compatible for MediaTek MT8195 xinlei.lee
2022-02-16 10:24 ` Krzysztof Kozlowski
2022-02-16 9:32 ` [v2,4/4] dt-bindings: pwm: Add compatible for MediaTek MT8186 xinlei.lee
2022-02-16 10:25 ` Krzysztof Kozlowski
2022-02-24 21:19 ` Rob Herring
[not found] ` <acc635f9e6d4f6f278ac334b13e96ce30c8c8b1d.camel@mediatek.com>
2022-02-25 6:26 ` Chen-Yu Tsai
2022-02-16 9:47 ` [v2,0/4] Convert pwm-mtk-disp.txt to mediatek,pwm-disp.yaml format Macpaul Lin
2022-02-16 10:19 ` Krzysztof Kozlowski
2022-02-16 10:24 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=370739d4-2da6-b620-ec79-adf8d00c8c33@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=allen-kh.cheng@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=jitao.shi@mediatek.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=xinlei.lee@mediatek.com \
--cc=xinlei.lee@mediatek.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).