From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 858A9C47094 for ; Mon, 14 Jun 2021 17:49:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69944611EE for ; Mon, 14 Jun 2021 17:49:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234012AbhFNRv6 (ORCPT ); Mon, 14 Jun 2021 13:51:58 -0400 Received: from m43-7.mailgun.net ([69.72.43.7]:34538 "EHLO m43-7.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233199AbhFNRv5 (ORCPT ); Mon, 14 Jun 2021 13:51:57 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1623692994; h=Message-ID: References: In-Reply-To: Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=KEdYtHQyiUtt7ZlGjdInmYZxYY3b99OgSBMH10I1Gwk=; b=m3Es+LktXPp17htWZitk5uAkzWqzc+w2qDHZ8COBlkrHOQFPFILDYl0iNqaqXEG9nEWl7xpZ CWERTvfIxBfEKY676YgjulBj15wJbs+us1L0IqIE2WnY9jSBvwOwwstxRvZ8mFfGx8Jhi1xF 57wNh9hZd41MeUwwLo+ebemimNE= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 60c796c02eaeb98b5e56864b (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Mon, 14 Jun 2021 17:49:52 GMT Sender: bbhatt=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 757D2C4323A; Mon, 14 Jun 2021 17:49:52 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: bbhatt) by smtp.codeaurora.org (Postfix) with ESMTPSA id 837CFC4338A; Mon, 14 Jun 2021 17:49:51 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 14 Jun 2021 10:49:51 -0700 From: Bhaumik Bhatt To: Kalle Valo Cc: Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, hemantk@codeaurora.org, jhugo@codeaurora.org, linux-kernel@vger.kernel.org, loic.poulain@linaro.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org Subject: Re: [PATCH v4 4/6] ath11k: set register access length for MHI driver Organization: Qualcomm Innovation Center, Inc. Reply-To: bbhatt@codeaurora.org Mail-Reply-To: bbhatt@codeaurora.org In-Reply-To: <87h7i0juxt.fsf@codeaurora.org> References: <1620330705-40192-1-git-send-email-bbhatt@codeaurora.org> <1620330705-40192-5-git-send-email-bbhatt@codeaurora.org> <20210521135152.GL70095@thinkpad> <87h7i0juxt.fsf@codeaurora.org> Message-ID: <37184e28dcc952ba9ad5ed0dc2c1a6da@codeaurora.org> X-Sender: bbhatt@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kalle, On 2021-06-14 09:02 AM, Kalle Valo wrote: > Manivannan Sadhasivam writes: > >> On Thu, May 06, 2021 at 12:51:43PM -0700, Bhaumik Bhatt wrote: >>> MHI driver requires register space length to add range checks and >>> prevent memory region accesses outside of that for MMIO space. >>> Set it before registering the MHI controller. >>> >>> Signed-off-by: Bhaumik Bhatt >>> Reviewed-by: Hemant Kumar >> >> Reviewed-by: Manivannan Sadhasivam >> >> Kalle, should we do immutable branch for this patch or I can pick it >> up via MHI >> tree (if there are no other patches expected from ath11k for this >> controller)? > > I'm not expecting any conflicts with this, and if there are, they > should > be easy for Stephen or Linus to fix. So it's easiest to route this via > your tree. But I'm not giving my ack yet, see below. > > I'm worried that this patchset breaks bisect. Every patch in the > patchset should not break existing functionality, what if only patches > 1-3 are included in the tree but not patch 4? Wouldn't ath11k be broken > then? I didn't review the whole patchset, but I suspect the fix is to > include the ath11k change in the actual mhi patch which changes the > functionality. So that way we would not have a separate ath11k patch at > all. > > Also I'm not able to test this patchset at the moment. Can someone else > help and do a quick test with QCA6390 to verify these doesn't break > ath11k? I have requested someone to try and test this patch series with QCA6390. I or the testers will get back to you with the test results when they are available. As far as your concerns go, you can choose to pick patches 1-3 and that would be just fine. Things will break if patchset 4 is _not_ in place with patchset 6 being part of the tree. It would, however, be nice to pick the whole series instead and ensure that the functionality MHI introduces for boot-up sanity is in place for any controllers such as ath11k. Thanks, Bhaumik --- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project