From: Wei Xu <xuwei5@hisilicon.com>
To: Vincent Guittot <vincent.guittot@linaro.org>,
<robh+dt@kernel.org>, <mark.rutland@arm.com>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linus.walleij@linaro.org>
Subject: Re: [PATCH v2] arm64/hisilicon: fix SDcard detection
Date: Fri, 1 Feb 2019 17:00:18 +0000 [thread overview]
Message-ID: <3722223a-4f06-3e1c-86ca-542289c7c918@hisilicon.com> (raw)
In-Reply-To: <1547454274-1674-1-git-send-email-vincent.guittot@linaro.org>
Hi Vincent,
On 1/14/2019 8:24 AM, Vincent Guittot wrote:
> The SDcard detection of hikey960 is active low so cd-inverted is wrong.
> Instead of adding cd-inverted, we should better set correctly cd-gpios
> to use GPIO_ACTIVE_LOW.
>
> Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Updated the subject as Leo suggested and applied to the hisilicon tree.
Thanks!
Best Regards,
Wei
> ---
>
> SD card detection was not working on v5.0-rc1 but patch
> https://marc.info/?l=linux-mmc&m=154637189021211&w=2 makes it work.
> Nevertheles, latest changes in of_mmc_detection makes possible to have
> a correct DT config.
>
> arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> index 71bfe41..dc314e7 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts
> @@ -665,8 +665,7 @@
> sd-uhs-sdr50;
> sd-uhs-sdr104;
> disable-wp;
> - cd-inverted;
> - cd-gpios = <&gpio25 3 0>;
> + cd-gpios = <&gpio25 3 GPIO_ACTIVE_LOW>;
> pinctrl-names = "default";
> pinctrl-0 = <&sd_pmx_func
> &sd_clk_cfg_func
>
next prev parent reply other threads:[~2019-02-01 17:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 8:24 [PATCH v2] arm64/hisilicon: fix SDcard detection Vincent Guittot
2019-01-14 8:28 ` Linus Walleij
2019-01-14 8:36 ` Leo Yan
2019-02-01 17:00 ` Wei Xu [this message]
2019-02-02 8:52 ` Vincent Guittot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3722223a-4f06-3e1c-86ca-542289c7c918@hisilicon.com \
--to=xuwei5@hisilicon.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).