From: "Petr Vandrovec" <VANDROVE@vc.cvut.cz>
To: andrew may <acmay@acmay.homeip.net>
Cc: Ani Joshi <ajoshi@shell.unixbox.com>, linux-kernel@vger.kernel.org
Subject: Re: missing break? linux/drivers/video/riva/fbdev.c
Date: Fri, 14 Sep 2001 18:09:58 MET-1 [thread overview]
Message-ID: <372A2445C86@vcnet.vc.cvut.cz> (raw)
On 13 Sep 01 at 21:26, andrew may wrote:
> diff -u --recursive --new-file v2.4.9/linux/drivers/video/riva/fbdev.c linux/drivers/video/riva/fbdev.c
> --- v2.4.9/linux/drivers/video/riva/fbdev.c Wed Jul 25 17:10:24 2001
> +++ linux/drivers/video/riva/fbdev.c Fri Sep 7 09:28:38 2001
> @@ -1109,6 +1109,8 @@
> break;
> #endif
> #ifdef FBCON_HAS_CFB16
> + case 15:
> + rc = 15; /* fix for 15 bpp depths on Riva 128 based cards */
> case 16:
> rc = 16; /* directcolor... 16 entries SW palette */
> break; /* Mystique: truecolor, 16 entries SW palette, HW palette hardwired into 1:1 mapping */
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
I do not think that this comment should be in rivafb driver ;-) It
is completely unrelated to Riva hardware, it came from matroxfb.
Best regards,
Petr Vandrovec
vandrove@vc.cvut.cz
next reply other threads:[~2001-09-14 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-09-14 18:09 Petr Vandrovec [this message]
-- strict thread matches above, loose matches on Subject: below --
2001-09-14 4:26 missing break? linux/drivers/video/riva/fbdev.c andrew may
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=372A2445C86@vcnet.vc.cvut.cz \
--to=vandrove@vc.cvut.cz \
--cc=acmay@acmay.homeip.net \
--cc=ajoshi@shell.unixbox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).