From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754334AbdKAJSM (ORCPT ); Wed, 1 Nov 2017 05:18:12 -0400 Received: from mail.thorsis.com ([213.211.200.15]:37177 "EHLO mail.thorsis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752310AbdKAJSL (ORCPT ); Wed, 1 Nov 2017 05:18:11 -0400 X-Greylist: delayed 597 seconds by postgrey-1.27 at vger.kernel.org; Wed, 01 Nov 2017 05:18:10 EDT From: Alexander Dahl To: Colin King Cc: Nicolas Ferre , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: macb: remove redundant assignment to variable work_done Date: Wed, 01 Nov 2017 10:08:07 +0100 Message-ID: <3739420.Z09RPnxjzp@ada> In-Reply-To: <20171031142324.25740-1-colin.king@canonical.com> References: <20171031142324.25740-1-colin.king@canonical.com> Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hei hei, Am Dienstag, 31. Oktober 2017, 14:23:24 CET schrieb Colin King: > --- a/drivers/net/ethernet/cadence/macb_main.c > +++ b/drivers/net/ethernet/cadence/macb_main.c > @@ -1218,8 +1218,6 @@ static int macb_poll(struct napi_struct *napi, int > budget) status = macb_readl(bp, RSR); > macb_writel(bp, RSR, status); > > - work_done = 0; > - > netdev_vdbg(bp->dev, "poll: status = %08lx, budget = %d\n", > (unsigned long)status, budget); Looks reasonable, when looking at the surrounding code. Applied this on top of 4.14-rc7 and tested it on an at91sam9g20 based platform. Tested-by: Alexander Dahl Greets Alex