From: Joe Perches <joe@perches.com>
To: Eric Dumazet <edumazet@google.com>
Cc: Willy Tarreau <w@1wt.eu>,
wanghaifine@gmail.com, David Miller <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Change judgment len position
Date: Wed, 24 Oct 2018 10:18:31 -0700 [thread overview]
Message-ID: <375561cf08343abbcd4118da2272507c30311788.camel@perches.com> (raw)
In-Reply-To: <CANn89iLH=VP1i=KS5QV1x41EpQM5-o1TJfDh01Y++bMpFpfBRg@mail.gmail.com>
On Wed, 2018-10-24 at 10:03 -0700, Eric Dumazet wrote:
> On Wed, Oct 24, 2018 at 9:54 AM Joe Perches <joe@perches.com> wrote:
>
> > I think if the point is to test for negative numbers,
> > it's clearer to do that before using min_t.and it's
> > probably clearer not to use min_t at all.
> >
>
> ...
>
> > if (len > sizeof(int))
> > len = sizeof(int);
>
> It is a matter of taste really,
Agree and hence my use of 'I think' above.
> I know some people (like me) sometimes
> mixes min() and max()
Not quite sure what you mean here by mixes.
mix up? If so, the < > inversions probably
have about the same error rate.
And I suppose there are cases where the
always set of len in uses like
len = min(len, 4);
are more costly (len being in a slow write
speed area of memory or some such) than the
other style of
if (len < 4)
len = 4;
I think that min() is easier to read in most
cases.
> I would suggest that if someones wants to change the current code, a
> corresponding test would be added in tools/testing/selftests/net?
next prev parent reply other threads:[~2018-10-24 17:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 15:47 [PATCH] Change judgment len position Wang Hai
2018-10-24 15:57 ` Willy Tarreau
2018-10-24 16:23 ` Joe Perches
2018-10-24 16:32 ` Willy Tarreau
2018-10-24 16:54 ` Joe Perches
2018-10-24 17:03 ` Eric Dumazet
2018-10-24 17:18 ` Joe Perches [this message]
2018-10-24 20:09 ` Willy Tarreau
2018-10-24 15:59 ` Eric Dumazet
2018-10-24 16:01 ` Willy Tarreau
2018-10-24 17:10 ` David Miller
2018-10-24 18:28 ` Joe Perches
2018-10-24 20:48 ` Willy Tarreau
2018-10-24 23:46 ` Joe Perches
2018-10-25 0:02 ` David Miller
2018-10-25 0:23 ` Joe Perches
2018-10-25 0:50 ` Eric Dumazet
2018-10-25 1:11 ` Fengguang Wu
2018-10-25 1:16 ` Joe Perches
2018-10-25 2:20 ` Al Viro
2018-10-25 2:41 ` Joe Perches
2018-10-25 3:20 ` Willy Tarreau
2018-10-25 1:03 ` Al Viro
2018-10-24 17:34 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=375561cf08343abbcd4118da2272507c30311788.camel@perches.com \
--to=joe@perches.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=w@1wt.eu \
--cc=wanghaifine@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).