From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753457AbcHUToV (ORCPT ); Sun, 21 Aug 2016 15:44:21 -0400 Received: from mout.web.de ([217.72.192.78]:58464 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752863AbcHUToU (ORCPT ); Sun, 21 Aug 2016 15:44:20 -0400 Subject: [PATCH 1/2] ALSA: compress: Use memdup_user() rather than duplicating its implementation To: alsa-devel@alsa-project.org, Jaroslav Kysela , Takashi Iwai , Vinod Koul References: <566ABCD9.1060404@users.sourceforge.net> <7233eb00-a941-4935-dce2-7cb907272d41@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall From: SF Markus Elfring Message-ID: <375fcd8c-ebb5-5f63-f094-347559c5b9c1@users.sourceforge.net> Date: Sun, 21 Aug 2016 21:43:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <7233eb00-a941-4935-dce2-7cb907272d41@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:+qm+7ZTv8hl0vW3jRqgct2oOc6KYP05wtaEtwnu1OAy+6EZRmx/ OPsd062XyPkAZpuS4VvQHSBKozlXd+a+e+qsSKOtoSicMihZgXbSpJnjQQfYcyi81Wec5jk 2fzPipagaimpGgjQ8RIC8L8YEkJpZbFZcKbHI88j2NzLrthTc46ELFTv4I7iomKIx3+a/li XHbJ/uG2dCGEucYAGTw9A== X-UI-Out-Filterresults: notjunk:1;V01:K0:L2vjtBVAKVY=:+kmXYZA0o8zfTcbELXsvCS kvkACrjezLyjOhBXW0vgFS1WGgmdpZNZG25bxPNvqdqLTejBZoCOn5KULnj09kyrlpUtalRED Pd8pmDe0NzKppEU2CRhXQ4JLD/R4aqAwjY1FJQzbyiOho6kv4+yFUSKadyoyavt2FKNGyBYu2 Ex/fMQ6FVu97wqSgGhiA6p5hp3OUkClcwjlu8iXhmjor6AsY71WxLMu0g/VBGASQAKYJplJEI hXuXMeIuff9w7SY60clpytobChK7Lkz1eQ5xzqIeXv5WtqU6OjAkHXV4WnvHo3K5CQARyuQgl ZwO1psiV4kFFU1RhFwBsCvh750DfcngK5iiiSc8wuq5Tq+MkX6/SUb7CsDvQCoieDNvGhtMBS qKbpAIaH9j37RWLW5JN0aWZb5vZ5h0rU0ABO1Fax2r7HX2W4XCeVK3xkLupNAsSuN6XFApP2S 6HYx5hYE/vzDMqCMOhSCOFHLAnaylc6QhPdEwR1kj33pv9awL857GM8Zng1OIboh2KorGXXQj eHUUbEsDBw26K5QRbFbZU3+Unv9uMM3Enbz6ga3sFvSENqvimeqn/UwaCB/XElqUUz14gPTrA IYPTa0ufvoSTgd0FgscEMw/vva8Hr6BE56Ceb2erFN8V79hVXhwkKlslMtx1f4nnnVcnVkH9R 2DPvrjg4EEjH8F/mAnOmNP2GRsHinB5JSzutb9MQZfUqO5vzmcIhmz83rPFLVirZyH2ffT9T6 ZY7E8H7JOg8F/aNrkkDYsZo0W43KoCheCJ7ASvU8hkcaylUA/tP+50SUj8T8xzLE+orJVCXdm te5MOSu Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 21 Aug 2016 21:02:06 +0200 Reuse existing functionality from memdup_user() instead of keeping duplicate source code. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- sound/core/compress_offload.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c index 2c49848..583d407 100644 --- a/sound/core/compress_offload.c +++ b/sound/core/compress_offload.c @@ -553,13 +553,9 @@ snd_compr_set_params(struct snd_compr_stream *stream, unsigned long arg) * we should allow parameter change only when stream has been * opened not in other cases */ - params = kmalloc(sizeof(*params), GFP_KERNEL); - if (!params) - return -ENOMEM; - if (copy_from_user(params, (void __user *)arg, sizeof(*params))) { - retval = -EFAULT; - goto out; - } + params = memdup_user((void __user *)arg, sizeof(*params)); + if (IS_ERR(params)) + return PTR_ERR(params); retval = snd_compress_check_input(params); if (retval) -- 2.9.3