From: Netanel Belgazal <netanel@annapurnalabs.com>
To: Matt Wilson <msw@amzn.com>
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, dwmw@amazon.com, zorik@annapurnalabs.com,
alex@annapurnalabs.com, saeed@annapurnalabs.com, msw@amazon.com,
aliguori@amazon.com, nafea@annapurnalabs.com
Subject: Re: [PATCH V2 net 04/20] net/ena: fix ethtool RSS flow configuration
Date: Mon, 5 Dec 2016 20:26:40 +0200 [thread overview]
Message-ID: <376d4953-277e-b10d-bf71-1c4e05954a7c@annapurnalabs.com> (raw)
In-Reply-To: <20161205041815.GE4310@u54ee753d2d1854bda401.ant.amazon.com>
On 12/05/2016 06:18 AM, Matt Wilson wrote:
> On Sun, Dec 04, 2016 at 03:19:22PM +0200, Netanel Belgazal wrote:
>> ena_flow_data_to_flow_hash and ena_flow_hash_to_flow_type
>> treat the ena_flow_hash_to_flow_type enum as power of two values.
>>
>> Change the values of ena_admin_flow_hash_fields to be power of two values.
> Then I generally prefer BIT(0), BIT(1), BIT(2), etc.
I'll use BIT(x)
>
> Also it would be helpful to include some comments about the
> consequences of the current state of the code.
I'll add explanation.
>
> --msw
>
>> Signed-off-by: Netanel Belgazal <netanel@annapurnalabs.com>
>> ---
>> drivers/net/ethernet/amazon/ena/ena_admin_defs.h | 12 ++++++------
>> 1 file changed, 6 insertions(+), 6 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/amazon/ena/ena_admin_defs.h b/drivers/net/ethernet/amazon/ena/ena_admin_defs.h
>> index a46e749..f48c886 100644
>> --- a/drivers/net/ethernet/amazon/ena/ena_admin_defs.h
>> +++ b/drivers/net/ethernet/amazon/ena/ena_admin_defs.h
>> @@ -631,22 +631,22 @@ enum ena_admin_flow_hash_proto {
>> /* RSS flow hash fields */
>> enum ena_admin_flow_hash_fields {
>> /* Ethernet Dest Addr */
>> - ENA_ADMIN_RSS_L2_DA = 0,
>> + ENA_ADMIN_RSS_L2_DA = 0x1,
>>
>> /* Ethernet Src Addr */
>> - ENA_ADMIN_RSS_L2_SA = 1,
>> + ENA_ADMIN_RSS_L2_SA = 0x2,
>>
>> /* ipv4/6 Dest Addr */
>> - ENA_ADMIN_RSS_L3_DA = 2,
>> + ENA_ADMIN_RSS_L3_DA = 0x4,
>>
>> /* ipv4/6 Src Addr */
>> - ENA_ADMIN_RSS_L3_SA = 5,
>> + ENA_ADMIN_RSS_L3_SA = 0x8,
>>
>> /* tcp/udp Dest Port */
>> - ENA_ADMIN_RSS_L4_DP = 6,
>> + ENA_ADMIN_RSS_L4_DP = 0x10,
>>
>> /* tcp/udp Src Port */
>> - ENA_ADMIN_RSS_L4_SP = 7,
>> + ENA_ADMIN_RSS_L4_SP = 0x20,
>> };
>>
>> struct ena_admin_proto_input {
next prev parent reply other threads:[~2016-12-05 18:26 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-04 13:19 [PATCH V2 net 00/20] Increase ENA driver version to 1.1.2 Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 01/20] net/ena: remove ntuple filter support from device feature list Netanel Belgazal
2016-12-05 4:08 ` Matt Wilson
2016-12-04 13:19 ` [PATCH V2 net 02/20] net/ena: fix error handling when probe fails Netanel Belgazal
2016-12-05 4:09 ` Matt Wilson
2016-12-05 18:23 ` Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 03/20] net/ena: fix queues number calculation Netanel Belgazal
2016-12-05 4:11 ` Matt Wilson
2016-12-05 18:25 ` Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 04/20] net/ena: fix ethtool RSS flow configuration Netanel Belgazal
2016-12-05 4:18 ` Matt Wilson
2016-12-05 18:26 ` Netanel Belgazal [this message]
2016-12-04 13:19 ` [PATCH V2 net 05/20] net/ena: fix RSS default hash configuration Netanel Belgazal
2016-12-05 4:20 ` Matt Wilson
2016-12-05 18:32 ` Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 06/20] net/ena: fix NULL dereference when removing the driver after device reset faild Netanel Belgazal
2016-12-05 4:29 ` Matt Wilson
2016-12-05 18:30 ` Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 07/20] net/ena: refactor ena_get_stats64 to be atomic context safe Netanel Belgazal
2016-12-05 4:24 ` Matt Wilson
2016-12-05 18:29 ` Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 08/20] net/ena: add hardware hints capability to the driver Netanel Belgazal
2016-12-05 4:31 ` Matt Wilson
2016-12-05 18:31 ` Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 09/20] net/ena: fix potential access to freed memory during device reset Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 10/20] net/ena: remove redundant logic in napi callback for busy poll mode Netanel Belgazal
2016-12-05 5:45 ` Eric Dumazet
2016-12-05 18:29 ` Netanel Belgazal
2016-12-05 18:51 ` Eric Dumazet
2016-12-04 13:19 ` [PATCH V2 net 11/20] net/ena: use READ_ONCE to access completion descriptors Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 12/20] net/ena: reduce the severity of ena printouts Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 13/20] net/ena: change driver's default timeouts Netanel Belgazal
2016-12-05 4:35 ` Matt Wilson
2016-12-05 18:28 ` Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 14/20] net/ena: change condition for host attribute configuration Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 15/20] net/ena: change sizeof() argument to be the type pointer Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 16/20] net/ena: use napi_schedule_irqoff when possible Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 17/20] net/ena: add IPv6 extended protocols to ena_admin_flow_hash_proto Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 18/20] net/ena: remove affinity hint from the driver Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 19/20] net/ena: restructure skb allocation Netanel Belgazal
2016-12-04 13:19 ` [PATCH V2 net 20/20] net/ena: increase driver version to 1.1.2 Netanel Belgazal
2016-12-05 2:37 ` [PATCH V2 net 00/20] Increase ENA " David Miller
2016-12-05 3:30 ` Matt Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=376d4953-277e-b10d-bf71-1c4e05954a7c@annapurnalabs.com \
--to=netanel@annapurnalabs.com \
--cc=alex@annapurnalabs.com \
--cc=aliguori@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=msw@amazon.com \
--cc=msw@amzn.com \
--cc=nafea@annapurnalabs.com \
--cc=netdev@vger.kernel.org \
--cc=saeed@annapurnalabs.com \
--cc=zorik@annapurnalabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).