From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jonathan Bakker <xc-racer2@live.ca>, alim.akhtar@samsung.com
Cc: robh+dt@kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] ARM: dts: s5pv210: Split memory nodes to match spec
Date: Thu, 24 Mar 2022 12:23:11 +0100 [thread overview]
Message-ID: <377e97c2-03e4-bc74-595d-2f4dba7e142f@kernel.org> (raw)
In-Reply-To: <CY4PR04MB05671F31023376B0B7050C68CB189@CY4PR04MB0567.namprd04.prod.outlook.com>
On 23/03/2022 18:05, Jonathan Bakker wrote:
>
>
> On 2022-03-23 8:06 a.m., Krzysztof Kozlowski wrote:
>> On 23/03/2022 15:59, Jonathan Bakker wrote:
>>> Hi Krzysztof,
>>>
>>> On 2022-03-23 3:54 a.m., Krzysztof Kozlowski wrote:
>>>> On 22/03/2022 21:11, Jonathan Bakker wrote:
>>>>> Memory nodes should only have a singular reg property in them, so
>>>>> split the memory nodes such that there is only per node.
>>>>>
>>>>> Signed-off-by: Jonathan Bakker <xc-racer2@live.ca>
>>>>> ---
>>>>> arch/arm/boot/dts/s5pv210-aquila.dts | 8 ++++++--
>>>>> arch/arm/boot/dts/s5pv210-aries.dtsi | 14 +++++++++++---
>>>>> arch/arm/boot/dts/s5pv210-goni.dts | 14 +++++++++++---
>>>>> 3 files changed, 28 insertions(+), 8 deletions(-)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/s5pv210-aquila.dts b/arch/arm/boot/dts/s5pv210-aquila.dts
>>>>> index 6423348034b6..6984479ddba3 100644
>>>>> --- a/arch/arm/boot/dts/s5pv210-aquila.dts
>>>>> +++ b/arch/arm/boot/dts/s5pv210-aquila.dts
>>>>> @@ -29,8 +29,12 @@
>>>>>
>>>>> memory@30000000 {
>>>>> device_type = "memory";
>>>>> - reg = <0x30000000 0x05000000
>>>>> - 0x40000000 0x18000000>;
>>>>> + reg = <0x30000000 0x05000000>;
>>>>> + };
>>>>> +
>>>>> + memory@40000000 {
>>>>> + device_type = "memory";
>>>>> + reg = <0x40000000 0x18000000>;
>>>>> };
>>>>>
>>>>> pmic_ap_clk: clock-0 {
>>>>> diff --git a/arch/arm/boot/dts/s5pv210-aries.dtsi b/arch/arm/boot/dts/s5pv210-aries.dtsi
>>>>> index 160f8cd9a68d..70ff56daf4cb 100644
>>>>> --- a/arch/arm/boot/dts/s5pv210-aries.dtsi
>>>>> +++ b/arch/arm/boot/dts/s5pv210-aries.dtsi
>>>>> @@ -24,9 +24,17 @@
>>>>>
>>>>> memory@30000000 {
>>>>> device_type = "memory";
>>>>> - reg = <0x30000000 0x05000000
>>>>> - 0x40000000 0x10000000
>>>>> - 0x50000000 0x08000000>;
>>>>
>>>> 0x40000000 to 0x58000000 is continues, so I wonder why it is split? Look
>>>> at Aquila DTS.
>>>>
>>>>
>>>
>>> Yes, it was split in the vendor kernel as well [1], and that's been continued along
>>> here. I personally don't see a reason to keep it split, but there might be something
>>> I'm not aware of.
>>>
>>
>> I guess they wanted maybe to express the physical banks. Fine with me.
>> Just your explanation is not entirely correct:
>>> Memory nodes should only have a singular reg property in them,
>> one reg but it can have multiple items. Why do think multiple reg items
>> is not allowed?
>>
>
> I was basing it off of this warning when running make dtbs_check
>
> rch/arm/boot/dts/s5pv210-aquila.dt.yaml: /: memory@30000000:reg:0: [805306368, 83886080, 1073741824, 402653184] is too long
> From schema: /home/jon/.local/lib/python3.7/site-packages/dtschema/schemas/reg.yaml
>
> and this solved the warning, booted, and I still had the correct
> amount of memory.
>
> Would
>
> memory@30000000 {
> device_type = "memory";
> reg = <0x30000000 0x05000000>,
> <0x40000000 0x18000000>;
> };
>
> be equally correct? (untested).
Yes, this one should be correct.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-24 11:23 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220322201144.20320-1-xc-racer2@live.ca>
2022-03-22 20:11 ` [PATCH 1/7] ARM: dts: s5pv210: Split memory nodes to match spec Jonathan Bakker
2022-03-23 10:54 ` Krzysztof Kozlowski
2022-03-23 14:59 ` Jonathan Bakker
2022-03-23 15:06 ` Krzysztof Kozlowski
2022-03-23 17:05 ` Jonathan Bakker
2022-03-24 11:23 ` Krzysztof Kozlowski [this message]
2022-03-23 15:03 ` [PATCH 2/7] ARM: dts: s5pv210: Adjust I2S entries " Jonathan Bakker
2022-03-23 15:14 ` Krzysztof Kozlowski
2022-03-23 15:15 ` Krzysztof Kozlowski
2022-03-23 17:24 ` Jonathan Bakker
2022-03-24 11:49 ` Krzysztof Kozlowski
2023-04-21 9:44 ` Krzysztof Kozlowski
2023-05-03 2:33 ` Jonathan Bakker
[not found] ` <20220323150311.26699-1-xc-racer2@live.ca>
2022-03-23 15:03 ` [PATCH 3/7] ARM: dts: s5pv210: Adjust DMA node names " Jonathan Bakker
2022-03-23 15:03 ` [PATCH 4/7] ARM: dts: s5pv210: Remove spi-cs-high on panel in Aries Jonathan Bakker
2022-03-23 15:22 ` Krzysztof Kozlowski
2022-03-23 15:03 ` [PATCH 5/7] ARM: dts: s5pv210: Correct interrupt name for bluetooth " Jonathan Bakker
2022-03-23 15:23 ` krzk
2022-03-23 15:03 ` [PATCH 6/7] ARM: dts: s5pv210: Add charger regulator to max8998 " Jonathan Bakker
2022-03-23 15:03 ` [PATCH 7/7] ARM: dts: s5pv210: Add charger support " Jonathan Bakker
2022-03-23 15:31 ` krzk
2022-03-23 17:20 ` Jonathan Bakker
2022-03-24 11:47 ` Krzysztof Kozlowski
2022-03-25 2:23 ` Jonathan Bakker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=377e97c2-03e4-bc74-595d-2f4dba7e142f@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=xc-racer2@live.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).