From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751523AbdIEI5t (ORCPT <rfc822;w@1wt.eu>);
        Tue, 5 Sep 2017 04:57:49 -0400
Received: from fllnx210.ext.ti.com ([198.47.19.17]:54701 "EHLO
        fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751582AbdIEI5o (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 5 Sep 2017 04:57:44 -0400
Subject: Re: [PATCH 4/5] mmc: sdhci-omap: Add OMAP SDHCI driver
To: Adrian Hunter <adrian.hunter@intel.com>,
        Ulf Hansson <ulf.hansson@linaro.org>
References: <20170821074132.4622-1-kishon@ti.com>
 <20170821074132.4622-5-kishon@ti.com>
 <4f0a7225-1843-b353-1a2a-9adcb49554d3@intel.com>
 <c7972f00-ef62-1736-822f-ebf6822b6d33@ti.com>
 <dfe1b4e2-bcb5-c969-efe6-7cddd0eb0bf9@intel.com>
CC: Rob Herring <robh+dt@kernel.org>, Tony Lindgren <tony@atomide.com>,
        Sekhar Nori <nsekhar@ti.com>, Russell King <linux@armlinux.org.uk>,
        Ravikumar Kattekola <rk@ti.com>, <linux-mmc@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-omap@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
From: Kishon Vijay Abraham I <kishon@ti.com>
Message-ID: <3782edd2-af90-c6c9-1358-1721a1dae28f@ti.com>
Date: Tue, 5 Sep 2017 14:27:05 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.7.0
MIME-Version: 1.0
In-Reply-To: <dfe1b4e2-bcb5-c969-efe6-7cddd0eb0bf9@intel.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On Thursday 31 August 2017 06:32 PM, Adrian Hunter wrote:
> On 30/08/17 16:53, Kishon Vijay Abraham I wrote:
>> On Monday 28 August 2017 02:36 PM, Adrian Hunter wrote:
>>> On 21/08/17 10:41, Kishon Vijay Abraham I wrote:
>>>> +
>>>> +static void sdhci_omap_set_clock(struct sdhci_host *host, unsigned int clock)
>>>> +{
>>>> +	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
>>>> +	struct sdhci_omap_host *omap_host = sdhci_pltfm_priv(pltfm_host);
>>>> +	unsigned long clkdiv;
>>>> +
>>>> +	if (!clock)
>>>> +		return;
>>>
>>> Are you sure you don't want to stop the clock.
>>
>> There is never a case where the MMC core sends a request to stop the clock.
>> Maybe this check is not required at all.
> 
> It does when voltage switching e.g. mmc_set_uhs_voltage(), but host drivers
> should support the possibility anyway.

Indeed! Will fix it and send a new revision once everyone agrees on the dt binding.

Thanks
Kishon