From: David Ahern <dsahern@gmail.com>
To: Nathan Chancellor <natechancellor@gmail.com>,
David Ahern <dsahern@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Jakub Kicinski <kuba@kernel.org>
Cc: Roopa Prabhu <roopa@cumulusnetworks.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
clang-built-linux@googlegroups.com
Subject: Re: [PATCH net-next] nexthop: Fix type of event_type in call_nexthop_notifiers
Date: Wed, 27 May 2020 07:50:35 -0600 [thread overview]
Message-ID: <37961e7c-3f71-a095-f2c4-bd9e768fc05b@gmail.com> (raw)
In-Reply-To: <20200527080019.3489332-1-natechancellor@gmail.com>
On 5/27/20 2:00 AM, Nathan Chancellor wrote:
> Clang warns:
>
> net/ipv4/nexthop.c:841:30: warning: implicit conversion from enumeration
> type 'enum nexthop_event_type' to different enumeration type 'enum
> fib_event_type' [-Wenum-conversion]
> call_nexthop_notifiers(net, NEXTHOP_EVENT_DEL, nh);
> ~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~
> 1 warning generated.
>
> Use the right type for event_type so that clang does not warn.
>
> Fixes: 8590ceedb701 ("nexthop: add support for notifiers")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1038
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> net/ipv4/nexthop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: David Ahern <dsahern@gmail.com>
next prev parent reply other threads:[~2020-05-27 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 8:00 [PATCH net-next] nexthop: Fix type of event_type in call_nexthop_notifiers Nathan Chancellor
2020-05-27 13:50 ` David Ahern [this message]
2020-05-27 18:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37961e7c-3f71-a095-f2c4-bd9e768fc05b@gmail.com \
--to=dsahern@gmail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).