From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FFD1C433E9 for ; Thu, 11 Mar 2021 09:16:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E56A964E5F for ; Thu, 11 Mar 2021 09:16:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232014AbhCKJQA (ORCPT ); Thu, 11 Mar 2021 04:16:00 -0500 Received: from smtprelay0208.hostedemail.com ([216.40.44.208]:37850 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231882AbhCKJPi (ORCPT ); Thu, 11 Mar 2021 04:15:38 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id 7851E1806ECE7; Thu, 11 Mar 2021 09:15:37 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: cause26_620e79827709 X-Filterd-Recvd-Size: 1972 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf08.hostedemail.com (Postfix) with ESMTPA; Thu, 11 Mar 2021 09:15:36 +0000 (UTC) Message-ID: <379d4b58d82be1f871924c89e0db7bab367564fb.camel@perches.com> Subject: Re: [PATCH] staging: rtl8723bs: align comments From: Joe Perches To: Dan Carpenter , Fabio Aiuto Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Date: Thu, 11 Mar 2021 01:15:34 -0800 In-Reply-To: <20210310174830.GM2087@kadam> References: <20210310153717.GA5741@agape.jhs> <20210310174830.GM2087@kadam> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2021-03-10 at 20:48 +0300, Dan Carpenter wrote: > You need to have a space character after the '*'. Perhaps YA checkpatch test... --- scripts/checkpatch.pl | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index f42e5ba16d9b..0de553d52605 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3876,6 +3876,21 @@ sub process { } } +# Independent comment lines should have a space after the comment initiator + if ($line =~ /^\+[ \t]*($;+)/) { #leading comment + my $comment = trim(substr($rawline, $-[1], $+[1] - $-[1])); + if ($comment =~ m{^(/\*|\*/|\*|//)(.*)}) { + my $init = $1; + my $rest = $2; + if ($init =~ m{^(?:/\*|\*|//)$} && + $rest ne '' && + $rest !~ /^[\s\*=\-]/) { + WARN("COMMENT_STYLE", + "Comments generally use whitespace after the comment initiator\n" . $herecurr); + } + } + } + # check for missing blank lines after struct/union declarations # with exceptions for various attributes and macros if ($prevline =~ /^[\+ ]};?\s*$/ &&