linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laura Abbott <labbott@redhat.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>,
	Sumit Semwal <sumit.semwal@linaro.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: android: ion: Bail out upon SIGKILL when allocating memory.
Date: Mon, 1 Jul 2019 17:21:39 -0400	[thread overview]
Message-ID: <37ac2d6d-3fc6-53eb-c2cd-20c0e9ac2054@redhat.com> (raw)
In-Reply-To: <b863d9a0-ac5b-8187-4373-b0532cf60e76@i-love.sakura.ne.jp>

On 7/1/19 5:02 PM, Tetsuo Handa wrote:
> On 2019/07/01 23:02, Sumit Semwal wrote:
>>> Acked-by: Laura Abbott <labbott@redhat.com>
>> fwiw, Acked-by: Sumit Semwal <sumit.semwal@linaro.org>
> 
> Thank you for responding. You can carry this patch via whichever tree you like.
> 
> By the way, is "memory allocation from ion_system_heap_allocate() is calling
> ion_system_heap_shrink()"
> ( https://lkml.kernel.org/r/03763360-a7de-de87-eb90-ba7838143930@I-love.SAKURA.ne.jp )
> what we want? Such memory allocations might not want to call shrinkers...
> 

For what Ion gets typically used for we do want to be calling shrinkers.
I've had discussions with people in the past about the risk of Ion as
DoS vector due to its ability to allocate large amounts of memory.
At the very least, we probably shouldn't be trying to call the Ion shrinker
when we're in the middle of an ion allocation since shrinking won't do us
any good. We're in the process of re-working Ion at the moment so this
might be a good topic to bring up again.

Thanks,
Laura

      reply	other threads:[~2019-07-01 21:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12 20:53 INFO: task syz-executor can't die for more than 143 seconds syzbot
2019-06-13  2:53 ` syzbot
2019-06-14 10:16   ` [PATCH] kexec: Bail out upon SIGKILL when allocating memory Tetsuo Handa
2019-07-01 10:52     ` Tetsuo Handa
2019-07-24  2:54     ` Eric Biggers
2019-07-24  3:09       ` Tetsuo Handa
2019-06-21  9:58 ` INFO: task syz-executor can't die for more than 143 seconds Tetsuo Handa
2019-07-01 10:55   ` [PATCH] staging: android: ion: Bail out upon SIGKILL when allocating memory Tetsuo Handa
2019-07-01 11:36     ` Laura Abbott
2019-07-01 14:02       ` Sumit Semwal
2019-07-01 21:02         ` Tetsuo Handa
2019-07-01 21:21           ` Laura Abbott [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37ac2d6d-3fc6-53eb-c2cd-20c0e9ac2054@redhat.com \
    --to=labbott@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penguin-kernel@i-love.sakura.ne.jp \
    --cc=sumit.semwal@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).