linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Rob Herring <robh@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Stefano Stabellini <stefanos@xilinx.com>
Cc: "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Nicolas Ferre <nicolas.ferre@microchip.com>,
	Claudiu Beznea <claudiu.beznea@microchip.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	netdev <netdev@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Michal Simek <michal.simek@xilinx.com>
Subject: Re: [PATCH] dt-bindings: net: cdns,macb: Convert to json-schema
Date: Mon, 6 Dec 2021 13:16:04 +0100	[thread overview]
Message-ID: <37b26b32-5828-df7f-3f73-6b9a4ef9d4e4@xilinx.com> (raw)
In-Reply-To: <CAL_JsqJHkL_Asqd5WPc7rfqXkbz1dpYfR0zxp5erVCyLiHaJNQ@mail.gmail.com>

Hi,

On 12/2/21 16:53, Rob Herring wrote:
> On Thu, Dec 2, 2021 at 4:10 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>>
>> Hi Rob,
>>
>> CC Michal
>>
>> On Thu, Dec 2, 2021 at 12:25 AM Rob Herring <robh@kernel.org> wrote:
>>> On Fri, Nov 26, 2021 at 12:57:00PM +0100, Geert Uytterhoeven wrote:
>>>> Convert the Cadence MACB/GEM Ethernet controller Device Tree binding
>>>> documentation to json-schema.
>>>>
>>>> Re-add "cdns,gem" (removed in commit a217d8711da5c87f ("dt-bindings:
>>>> Remove PicoXcell bindings")) as there are active users on non-PicoXcell
>>>> platforms.
>>>> Add missing "ether_clk" clock.
>>>> Add missing properties.
>>>>
>>>> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>>
>>>> --- /dev/null
>>>> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
>>
>>>> +  '#stream-id-cells':
>>>> +    const: 1
>>>
>>> I can't figure out why you have this here. I'll drop it while applying.
>>
>> See arch/arm64/boot/dts/xilinx/zynqmp.dtsi and
>> drivers/iommu/arm/arm-smmu/arm-smmu.c.
>>
>> It wasn't clear to me if this is still needed, or legacy. Michal?
> 
> They should update to the iommu binding instead of the legacy smmu
> one. It's been around for years now.

At the beginning it was there for XEN usage which was using this legacy 
binding.
Stefano: Please confirm that it is not needed anymore that we can remove 
it for zynqmp and versal.

Thanks,
Michal


  reply	other threads:[~2021-12-06 12:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-26 11:57 [PATCH] dt-bindings: net: cdns,macb: Convert to json-schema Geert Uytterhoeven
2021-11-29 13:21 ` Nicolas Ferre
2021-12-01 23:25 ` Rob Herring
2021-12-02 10:10   ` Geert Uytterhoeven
2021-12-02 15:53     ` Rob Herring
2021-12-06 12:16       ` Michal Simek [this message]
2021-12-09  4:38       ` Harini Katakam
2021-12-01 23:27 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37b26b32-5828-df7f-3f73-6b9a4ef9d4e4@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=claudiu.beznea@microchip.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=geert@linux-m68k.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh@kernel.org \
    --cc=stefanos@xilinx.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).