From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Ravi Chandra Sadineni <ravisadineni@chromium.org>,
bleung@chromium.org, swboyd@chromium.org, tbroch@chromium.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/chrome: chromeos_tbmc : Report wake events.
Date: Thu, 19 Sep 2019 15:03:15 +0200 [thread overview]
Message-ID: <37bb8176-34c8-c711-b6be-d64d6aec68e6@collabora.com> (raw)
In-Reply-To: <20190830231404.60005-1-ravisadineni@chromium.org>
Hi,
On 31/8/19 1:14, Ravi Chandra Sadineni wrote:
> Mark chromeos_tbmc as wake capable and report wake events. This helps to
> abort suspend on seeing a tablet mode switch event when kernel is
> suspending. This also helps identifying if chroemos_tbmc is the wake
> source.
>
> Signed-off-by: Ravi Chandra Sadineni <ravisadineni@chromium.org>
Applied for 5.4, the patches went to linux-next some time ago but sorry for late
reply.
Thanks,
Enric
> ---
> drivers/platform/chrome/chromeos_tbmc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/platform/chrome/chromeos_tbmc.c b/drivers/platform/chrome/chromeos_tbmc.c
> index ce259ec9f990..d1cf8f3463ce 100644
> --- a/drivers/platform/chrome/chromeos_tbmc.c
> +++ b/drivers/platform/chrome/chromeos_tbmc.c
> @@ -47,6 +47,7 @@ static __maybe_unused int chromeos_tbmc_resume(struct device *dev)
>
> static void chromeos_tbmc_notify(struct acpi_device *adev, u32 event)
> {
> + acpi_pm_wakeup_event(&adev->dev);
> switch (event) {
> case 0x80:
> chromeos_tbmc_query_switch(adev, adev->driver_data);
> @@ -90,6 +91,7 @@ static int chromeos_tbmc_add(struct acpi_device *adev)
> dev_err(dev, "cannot register input device\n");
> return ret;
> }
> + device_init_wakeup(dev, true);
> return 0;
> }
>
>
prev parent reply other threads:[~2019-09-19 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 23:14 [PATCH] platform/chrome: chromeos_tbmc : Report wake events Ravi Chandra Sadineni
2019-09-04 8:09 ` Enric Balletbo i Serra
2019-09-19 13:03 ` Enric Balletbo i Serra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37bb8176-34c8-c711-b6be-d64d6aec68e6@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=bleung@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ravisadineni@chromium.org \
--cc=swboyd@chromium.org \
--cc=tbroch@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).