From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
jmattson@google.com, stable@vger.kernel.org
Subject: Re: [PATCH v2] KVM: x86: Allow guests to see MSR_IA32_TSX_CTRL even if tsx=off
Date: Mon, 1 Feb 2021 09:46:38 +0100 [thread overview]
Message-ID: <37be5fb8-056f-8fba-3016-464634e069af@redhat.com> (raw)
In-Reply-To: <YBQ+peAEdX2h3tro@google.com>
On 29/01/21 17:58, Sean Christopherson wrote:
> On Fri, Jan 29, 2021, Paolo Bonzini wrote:
>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>> index 76bce832cade..15733013b266 100644
>> --- a/arch/x86/kvm/x86.c
>> +++ b/arch/x86/kvm/x86.c
>> @@ -1401,7 +1401,7 @@ static u64 kvm_get_arch_capabilities(void)
>> * This lets the guest use VERW to clear CPU buffers.
>
>
> This comment be updated to call out the new TSX_CTRL behavior.
>
> /*
> * On TAA affected systems:
> * - nothing to do if TSX is disabled on the host.
> * - we emulate TSX_CTRL if present on the host.
> * This lets the guest use VERW to clear CPU buffers.
> */
Ok.
>> */
>> if (!boot_cpu_has(X86_FEATURE_RTM))
>> - data &= ~(ARCH_CAP_TAA_NO | ARCH_CAP_TSX_CTRL_MSR);
>> + data &= ~ARCH_CAP_TAA_NO;
>
> Hmm, simply clearing TSX_CTRL will only preserve the host value. Since
> ARCH_CAPABILITIES is unconditionally emulated by KVM, wouldn't it make sense to
> unconditionally expose TSX_CTRL as well, as opposed to exposing it only if it's
> supported in the host? I.e. allow migrating a TSX-disabled guest to a host
> without TSX. Or am I misunderstanding how TSX_CTRL is checked/used?
I'm a bit wary of having a combination (MDS_NO=0, TSX_CTRL=1) that does
not exist on bare metal. There are other cases where such combinations
can happen, especially with the Spectre and SSBD mitigations (for
example due to AMD CPUID bits for Intel processors), but at least those
are just redundancies in the CPUID bits and it's more likely that the
guest does something sensible with them.
Paolo
>> else if (!boot_cpu_has_bug(X86_BUG_TAA))
>> data |= ARCH_CAP_TAA_NO;
>>
>> --
>> 2.26.2
>>
>
next prev parent reply other threads:[~2021-02-01 8:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-29 10:19 [PATCH v2] KVM: x86: Allow guests to see MSR_IA32_TSX_CTRL even if tsx=off Paolo Bonzini
2021-01-29 16:58 ` Sean Christopherson
2021-02-01 8:46 ` Paolo Bonzini [this message]
2021-02-01 9:08 ` Paolo Bonzini
2021-02-01 16:38 ` Sean Christopherson
2021-02-01 17:34 ` Paolo Bonzini
2021-02-01 17:36 ` Sean Christopherson
2021-02-01 17:03 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37be5fb8-056f-8fba-3016-464634e069af@redhat.com \
--to=pbonzini@redhat.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).