From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D39C5EB64DB for ; Tue, 20 Jun 2023 18:49:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229798AbjFTSs7 (ORCPT ); Tue, 20 Jun 2023 14:48:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229978AbjFTSsy (ORCPT ); Tue, 20 Jun 2023 14:48:54 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 184E11710; Tue, 20 Jun 2023 11:48:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1687286921; x=1718822921; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=cIjOp3qxDgmIfUXuVTvaRq9H0mpWEZcDYyV4VtVHbgs=; b=c68AKpRfMkgDRji7BAvfQgJHJFfJKZsbLstujxRqbgjTo3jAAe4Q+wGN hfLXmLjRlOZ/2uvSmu26XfZP9etzv2/Cbi4uYKv9NsGMU41P2KWWphWiP hmcqeqv4tI7nJ4Fmef81oe2OJUnIFmqs5omESPOczZa3o1cZxKBpsr/bY eqXrW1U2IlvtJ4Hz1Kfp+SzNC1fl9SaSGgS4oRdEi7239BXPZ+MNVy3Y2 j7BYlfSFHLNuQ2kFrrG+uEeOqAoE/JklFu/E+O3rVZfDwR3Ci2U1uB97P 9fGhzDP9lWpHbBGrhDqoJxPAiDPjU02VkN16mfwktcrrRfGdv5dQbiNCh A==; X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="358826313" X-IronPort-AV: E=Sophos;i="6.00,257,1681196400"; d="scan'208";a="358826313" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2023 11:48:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10747"; a="743878869" X-IronPort-AV: E=Sophos;i="6.00,257,1681196400"; d="scan'208";a="743878869" Received: from rashmigh-mobl.amr.corp.intel.com (HELO [10.255.228.28]) ([10.255.228.28]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Jun 2023 11:48:34 -0700 Message-ID: <37d2378e-72de-e474-5e25-656b691384ba@intel.com> Date: Tue, 20 Jun 2023 11:48:26 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 07/32] mm: Bring back vmalloc_exec Content-Language: en-US To: Andy Lutomirski , Kent Overstreet Cc: Mark Rutland , Linux Kernel Mailing List , linux-fsdevel@vger.kernel.org, "linux-bcachefs@vger.kernel.org" , Kent Overstreet , Andrew Morton , Uladzislau Rezki , "hch@infradead.org" , linux-mm@kvack.org, Kees Cook , the arch/x86 maintainers References: <20230509165657.1735798-1-kent.overstreet@linux.dev> <20230509165657.1735798-8-kent.overstreet@linux.dev> <20230619104717.3jvy77y3quou46u3@moria.home.lan> <20230619191740.2qmlza3inwycljih@moria.home.lan> <5ef2246b-9fe5-4206-acf0-0ce1f4469e6c@app.fastmail.com> <20230620180839.oodfav5cz234pph7@moria.home.lan> From: Dave Hansen In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> No, I'm saying your concerns are baseless and too vague to >> address. > If you don't address them, the NAK will stand forever, or at least > until a different group of people take over x86 maintainership. > That's fine with me. I've got a specific concern: I don't see vmalloc_exec() used in this series anywhere. I also don't see any of the actual assembly that's being generated, or the glue code that's calling into the generated assembly. I grepped around a bit in your git trees, but I also couldn't find it in there. Any chance you could help a guy out and point us to some of the specifics of this new, tiny JIT? >> Andy, I replied explaining the difference between text_poke() and >> text_poke_sync(). It's clear you have no idea what you're talking about, >> so I'm not going to be wasting my time on further communications with >> you. One more specific concern: This comment made me very uncomfortable and it read to me very much like a personal attack, something which is contrary to our code of conduct.