linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maulik Shah <mkshah@codeaurora.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	Andy Gross <agross@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	Lina Iyer <ilina@codeaurora.org>,
	Srinivas Rao L <lsrao@codeaurora.org>,
	Stephen Boyd <swboyd@chromium.org>
Subject: Re: [PATCH] drivers: qcom: rpmh-rsc: Do not read back the register write on trigger
Date: Wed, 9 Dec 2020 16:34:43 +0530	[thread overview]
Message-ID: <37d7a6e4-8773-6de2-8914-b39e656ed2f0@codeaurora.org> (raw)
In-Reply-To: <CAD=FV=XafiNR+vZc2nM6JzhU7xPm9v3eeeR5SMhBM3k3mmsZDQ@mail.gmail.com>

Hi Doug,

On 12/4/2020 2:47 AM, Doug Anderson wrote:
> Hi,
>
> On Thu, Dec 3, 2020 at 1:15 PM Doug Anderson <dianders@chromium.org> wrote:
>> Hi,
>>
>> On Tue, Nov 24, 2020 at 1:53 AM Maulik Shah <mkshah@codeaurora.org> wrote:
>>> From: Lina Iyer <ilina@codeaurora.org>
>>>
>>> When triggering a TCS to send its contents, reading back the trigger
>>> value may return an incorrect value. That is because, writing the
>>> trigger may raise an interrupt which could be handled immediately and
>>> the trigger value could be reset in the interrupt handler.
>>>
>>> A write_tcs_reg_sync() would read back the value that is written and try
>>> to match it to the value written to ensure that the value is written,
>>> but if that value is different, we may see false error for same.
>>>
>>> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
>>> Signed-off-by: Maulik Shah <mkshah@codeaurora.org>
>>> ---
>>>   drivers/soc/qcom/rpmh-rsc.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> Fixes: 658628e7ef78 ("drivers: qcom: rpmh-rsc: add RPMH controller for
>> QCOM SoCs")
>> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> Ugh, brain-fart.  Not Signed-off-by, but:
>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>

Thanks for the review, i will send v2 adding Fixes: tag.

Thanks,
Maulik

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation


      reply	other threads:[~2020-12-09 11:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-24  9:53 [PATCH] drivers: qcom: rpmh-rsc: Do not read back the register write on trigger Maulik Shah
2020-12-03 21:15 ` Doug Anderson
2020-12-03 21:17   ` Doug Anderson
2020-12-09 11:04     ` Maulik Shah [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37d7a6e4-8773-6de2-8914-b39e656ed2f0@codeaurora.org \
    --to=mkshah@codeaurora.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=dianders@chromium.org \
    --cc=ilina@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lsrao@codeaurora.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).