From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6357CC4167B for ; Wed, 9 Dec 2020 11:05:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1475C2336F for ; Wed, 9 Dec 2020 11:05:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730444AbgLILFy (ORCPT ); Wed, 9 Dec 2020 06:05:54 -0500 Received: from so254-31.mailgun.net ([198.61.254.31]:32041 "EHLO so254-31.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727753AbgLILFq (ORCPT ); Wed, 9 Dec 2020 06:05:46 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1607511924; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=R1eA7K+kLgc5Me1oF+PjqvgKANOliO8GkXvNmcPSg7A=; b=ZlQfFhIJi6kGOQPGBGdyGu6rSGdyyuZb38y9UU5O4AHZOr02A2zYBRtXGilrS+KKlbHYg0/b ZBSrJFtxSn/dPxLfBjhVw+g3PXFZE3kk8YSpOJSEbM7WDrq0+7Gmw0+nf6CDCyn8CFe629WF xxCaXFdPmmxEU1IOmb7pY0gMrY8= X-Mailgun-Sending-Ip: 198.61.254.31 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n05.prod.us-west-2.postgun.com with SMTP id 5fd0af526d5c2f1d20013055 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 09 Dec 2020 11:04:50 GMT Sender: mkshah=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id B3D80C43461; Wed, 9 Dec 2020 11:04:49 +0000 (UTC) Received: from [192.168.29.129] (unknown [49.36.77.97]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mkshah) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5FE48C433C6; Wed, 9 Dec 2020 11:04:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5FE48C433C6 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=mkshah@codeaurora.org Subject: Re: [PATCH] drivers: qcom: rpmh-rsc: Do not read back the register write on trigger To: Doug Anderson Cc: Bjorn Andersson , Andy Gross , LKML , linux-arm-msm , Lina Iyer , Srinivas Rao L , Stephen Boyd References: <1606211610-15168-1-git-send-email-mkshah@codeaurora.org> From: Maulik Shah Message-ID: <37d7a6e4-8773-6de2-8914-b39e656ed2f0@codeaurora.org> Date: Wed, 9 Dec 2020 16:34:43 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Doug, On 12/4/2020 2:47 AM, Doug Anderson wrote: > Hi, > > On Thu, Dec 3, 2020 at 1:15 PM Doug Anderson wrote: >> Hi, >> >> On Tue, Nov 24, 2020 at 1:53 AM Maulik Shah wrote: >>> From: Lina Iyer >>> >>> When triggering a TCS to send its contents, reading back the trigger >>> value may return an incorrect value. That is because, writing the >>> trigger may raise an interrupt which could be handled immediately and >>> the trigger value could be reset in the interrupt handler. >>> >>> A write_tcs_reg_sync() would read back the value that is written and try >>> to match it to the value written to ensure that the value is written, >>> but if that value is different, we may see false error for same. >>> >>> Signed-off-by: Lina Iyer >>> Signed-off-by: Maulik Shah >>> --- >>> drivers/soc/qcom/rpmh-rsc.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >> Fixes: 658628e7ef78 ("drivers: qcom: rpmh-rsc: add RPMH controller for >> QCOM SoCs") >> Signed-off-by: Douglas Anderson > Ugh, brain-fart. Not Signed-off-by, but: > > Reviewed-by: Douglas Anderson Thanks for the review, i will send v2 adding Fixes: tag. Thanks, Maulik -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation