From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEB8CC4320A for ; Mon, 2 Aug 2021 07:40:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D44660F9F for ; Mon, 2 Aug 2021 07:40:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232623AbhHBHk7 (ORCPT ); Mon, 2 Aug 2021 03:40:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33046 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232458AbhHBHk5 (ORCPT ); Mon, 2 Aug 2021 03:40:57 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 089BCC06175F; Mon, 2 Aug 2021 00:40:47 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id u20so22795834ljo.0; Mon, 02 Aug 2021 00:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Rx5q39Xw1a0JHH/JpOAv2dOieHFpmxEhCjzvGdgwxac=; b=O+AFu5KVOfglY6BISS0tHH7b0Xzrm+nN0tWvnQzROevDBptoTAvP/bfQ3ML7CgB3FP JXLxCKfbsURoiyfyg5E957Diq3HlUsYKoUOrMobARGJfZ0cdmwj8UgRWV4g7Pyco+WOw 7+x9Va79c14LJiNX7YvRiTNzx6WCiqe+kiN32G3DJIyG3+eKM8gFabYHCxLqUUpJm1WM AwayYKfaZD43bCHculSQ98usthauNdeqd6qtrYV/vSdITHS0oeLf4d1+aHZOAxeYx6sO N/guu698a+Q7nW3iPMEgrvc/rU1RoNfM1uSyZ2jItSI9JyxndvZw1qgedRcX9cVqKE4i 5uOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Rx5q39Xw1a0JHH/JpOAv2dOieHFpmxEhCjzvGdgwxac=; b=dtu7sDhSsDrPTm+SEVRWq+OA5cU3a3ru653GLAjOfw4yvX0E9vrn5AyQnhvJC15K1m ukaBXaxMQ3hscEw69U2BacDJ6c/TcbT22Uqy423MrB6hty53lfu/oVrF6+xmUVYnrHPC pmc6MzJGshzt3Yj21vNciOkHRuWlRuMdKW/7cg5ViFsvB1wswGvGWtXOAmSvV6r1q0Jc 1//cp8XKu8kwkjHdVUpnIz1MdUWNml/7Uyj78zJh0JHhxz1E8WSD7l1m4vNuMFsLfHhg OtMrraRekt4KfmHnDLAoTUBDcIhmrmVElV8VX/aw9LYCCWPQ+ycYO9fc+TpuLShK69ic FnBg== X-Gm-Message-State: AOAM530WOJyHk72TYEarCT+BqM5v5s94L/KN5xvNw3U3P0acPIDIGLcj R4ADP9niIvH3+a8Nm6eQnhG3kgidCwU= X-Google-Smtp-Source: ABdhPJwfOETjLE0hCokBQk+uH4O4MCFf15UDoXoQn73CRKGh6piOwZIRGA/ufgvwUUzzhcq2Iielog== X-Received: by 2002:a2e:a417:: with SMTP id p23mr10158364ljn.23.1627890045395; Mon, 02 Aug 2021 00:40:45 -0700 (PDT) Received: from [192.168.1.49] ([109.197.204.123]) by smtp.gmail.com with ESMTPSA id b23sm883533lff.65.2021.08.02.00.40.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Aug 2021 00:40:44 -0700 (PDT) Subject: Re: [PATCH v2 2/8] spi: spi-ep93xx: Prepare clock before using it To: Mark Brown , Nikita Shubin Cc: Geert Uytterhoeven , "open list:SPI SUBSYSTEM" , open list References: <20210726115058.23729-1-nikita.shubin@maquefel.me> <20210726140001.24820-1-nikita.shubin@maquefel.me> <20210726140001.24820-3-nikita.shubin@maquefel.me> <20210726165105.GI4670@sirena.org.uk> From: Alexander Sverdlin Message-ID: <37e15955-771f-56a8-cf8e-4342c3c2c3a3@gmail.com> Date: Mon, 2 Aug 2021 09:36:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210726165105.GI4670@sirena.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Mark, On 26/07/2021 18:51, Mark Brown wrote: > On Mon, Jul 26, 2021 at 04:59:50PM +0300, Nikita Shubin wrote: >> From: Alexander Sverdlin >> >> Use clk_prepare_enable()/clk_disable_unprepare() in preparation for switch >> to Common Clock Framework, otherwise the following is visible: > Acked-by: Mark Brown It looks like we didn't manage to bring the whole series as one lot to any maintainer and two patches were applied to two different trees. Could you please take this one to your tree as well? >> WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:1011 clk_core_enable+0x9c/0xbc >> Enabling unprepared ep93xx-spi.0 >> ... >> Hardware name: Cirrus Logic EDB9302 Evaluation Board >> ... >> clk_core_enable >> clk_core_enable_lock >> ep93xx_spi_prepare_hardware > Please think hard before including complete backtraces in upstream > reports, they are very large and contain almost no useful information > relative to their size so often obscure the relevant content in your > message. If part of the backtrace is usefully illustrative (it often is > for search engines if nothing else) then it's usually better to pull out > the relevant sections. Yes, I noted your comment first time and this was already stripped version of the backtrace, but please feel free to strip it even harder if you take the patch. Thank you for the review, -- Alex.