archive mirror
 help / color / mirror / Atom feed
From: Hannes Reinecke <>
To: Daniel Wagner <>,
Cc:, Sagi Grimberg <>,
Subject: Re: [PATCH] nvme-tcp: Do not reset transport on data digest errors
Date: Fri, 20 Aug 2021 12:20:43 +0200	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 8/5/21 2:15 PM, Daniel Wagner wrote:
> The spec says
> Digest Error handling
>    When a host detects a data digest error in a C2HData PDU, that host
>    shall continue processing C2HData PDUs associated with the command and
>    when the command processing has completed, if a successful status was
>    returned by the controller, the host shall fail the command with a
>    non-fatal transport error.
> Currently the transport is reseted when a data digest error is
> detected. To fix this, keep track of the final status in the queue
> object and use it when completing the request.
> The new member can be placed adjacent to the receive related members and
> fits in the cacheline as there is a 4 byte hole.
> Signed-off-by: Daniel Wagner <>
> ---
Reviewed-by: Hannes Reinecke <>


Dr. Hannes Reinecke                Kernel Storage Architect                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

      parent reply	other threads:[~2021-08-20 10:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 12:15 [PATCH] nvme-tcp: Do not reset transport on data digest errors Daniel Wagner
2021-08-06 19:42 ` Sagi Grimberg
2021-08-09  9:09   ` Daniel Wagner
2021-08-11  1:02     ` Sagi Grimberg
2021-08-11 10:31       ` Daniel Wagner
2021-08-18 12:44         ` Daniel Wagner
2021-08-23 17:13           ` Sagi Grimberg
2021-08-20 10:20 ` Hannes Reinecke [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).