From: Jan Kiszka <jan.kiszka@siemens.com>
To: Nishanth Menon <nm@ti.com>
Cc: Tero Kristo <kristo@kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
Bao Cheng Su <baocheng.su@siemens.com>,
Chao Zeng <chao.zeng@siemens.com>
Subject: Re: [PATCH 3/3] arm64: dts: ti: iot2050: Add support for product generation 2 boards
Date: Tue, 7 Sep 2021 17:27:33 +0200 [thread overview]
Message-ID: <37f18b9e-f640-2642-2849-ed5b61493bfa@siemens.com> (raw)
In-Reply-To: <20210907151648.5z4hnlgppurheloz@stroller>
On 07.09.21 17:16, Nishanth Menon wrote:
> On 16:22-20210907, Jan Kiszka wrote:
>> From: Jan Kiszka <jan.kiszka@siemens.com>
>>
>> Product Generations 1 and 2 differ in the SOC revision which requires
>> separate device trees.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> ---
>> arch/arm64/boot/dts/ti/Makefile | 2 +
>> .../dts/ti/k3-am65-iot2050-common-pg1.dtsi | 46 ++++++++++++++++
>> .../dts/ti/k3-am65-iot2050-common-pg2.dtsi | 51 ++++++++++++++++++
>> .../boot/dts/ti/k3-am65-iot2050-common.dtsi | 35 +-----------
>> ...ts => k3-am6528-iot2050-basic-common.dtsi} | 12 ++---
>> .../dts/ti/k3-am6528-iot2050-basic-pg2.dts | 21 ++++++++
>> .../boot/dts/ti/k3-am6528-iot2050-basic.dts | 53 ++-----------------
>> ...=> k3-am6548-iot2050-advanced-common.dtsi} | 8 +--
>> .../dts/ti/k3-am6548-iot2050-advanced-pg2.dts | 26 +++++++++
>> .../dts/ti/k3-am6548-iot2050-advanced.dts | 52 ++----------------
>> 10 files changed, 161 insertions(+), 145 deletions(-)
>> create mode 100644 arch/arm64/boot/dts/ti/k3-am65-iot2050-common-pg1.dtsi
>> create mode 100644 arch/arm64/boot/dts/ti/k3-am65-iot2050-common-pg2.dtsi
>> copy arch/arm64/boot/dts/ti/{k3-am6528-iot2050-basic.dts => k3-am6528-iot2050-basic-common.dtsi} (80%)
>> create mode 100644 arch/arm64/boot/dts/ti/k3-am6528-iot2050-basic-pg2.dts
>> copy arch/arm64/boot/dts/ti/{k3-am6548-iot2050-advanced.dts => k3-am6548-iot2050-advanced-common.dtsi} (86%)
>> create mode 100644 arch/arm64/boot/dts/ti/k3-am6548-iot2050-advanced-pg2.dts
>
>
> Few things:
>
> a) Could you split this patch so that the refactoring for SR1 is the
> first patch and then introduce the SR2?
Can do, sure
> b) Please call these as sr (silicon revision) rather than pg.
Nope, this is only motivated by the SR1->SR2 switch. The new products
are called "PG2", and that is what the DT name must reflect. Took me a
while to grasp that as well.
> c) usual request: Please add urls for the board
Where should they go? I think there is only one reasonable to share:
https://new.siemens.com/global/en/products/automation/pc-based/iot-gateways/simatic-iot2050.html
If that is a stable link, I can't tell.
Thanks
Jan
--
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2021-09-07 15:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 14:22 [PATCH 0/3] arm64: dts: Update IOT2050 boards Jan Kiszka
2021-09-07 14:22 ` [PATCH 1/3] arm64: dts: ti: iot2050: Flip mmc device ordering on Advanced devices Jan Kiszka
2021-09-07 15:13 ` Nishanth Menon
2021-09-07 15:20 ` Jan Kiszka
2021-09-07 15:27 ` Nishanth Menon
2021-09-07 15:30 ` Jan Kiszka
2021-09-07 15:35 ` Nishanth Menon
2021-09-07 16:47 ` Aswath Govindraju
2021-09-07 16:53 ` Nishanth Menon
2021-09-07 17:01 ` Aswath Govindraju
2021-09-07 20:28 ` Jan Kiszka
2021-09-08 2:47 ` Nishanth Menon
2021-09-07 14:22 ` [PATCH 2/3] arm64: dts: ti: iot2050: Disable SR2.0-only PRUs Jan Kiszka
2021-09-07 14:22 ` [PATCH 3/3] arm64: dts: ti: iot2050: Add support for product generation 2 boards Jan Kiszka
2021-09-07 15:16 ` Nishanth Menon
2021-09-07 15:27 ` Jan Kiszka [this message]
2021-09-07 15:37 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37f18b9e-f640-2642-2849-ed5b61493bfa@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=baocheng.su@siemens.com \
--cc=chao.zeng@siemens.com \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).