From: Vladimir Zapolskiy <vz@mleia.com>
To: zhong jiang <zhongjiang@huawei.com>
Cc: linux@armlinux.org.uk, slemieux.tyco@gmail.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm:pm: Use kmemdup to replace duplicating its implementation
Date: Mon, 13 Aug 2018 15:28:33 +0300 [thread overview]
Message-ID: <37f8ff09-b0c2-5cc6-87d4-8138e7b66b32@mleia.com> (raw)
In-Reply-To: <1533868851-316-1-git-send-email-zhongjiang@huawei.com>
Hi zhong jiang,
On 08/10/2018 05:40 AM, zhong jiang wrote:
> kmemdup is better than kmalloc() + memcpy(), and we do not like
> open code. So just use kmemdup instead.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> arch/arm/mach-lpc32xx/pm.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/mach-lpc32xx/pm.c b/arch/arm/mach-lpc32xx/pm.c
> index 6247157..6eefff8 100644
> --- a/arch/arm/mach-lpc32xx/pm.c
> +++ b/arch/arm/mach-lpc32xx/pm.c
> @@ -86,7 +86,8 @@ static int lpc32xx_pm_enter(suspend_state_t state)
> void *iram_swap_area;
>
> /* Allocate some space for temporary IRAM storage */
> - iram_swap_area = kmalloc(lpc32xx_sys_suspend_sz, GFP_KERNEL);
> + iram_swap_area = kmemdup((void *)TEMP_IRAM_AREA,
> + lpc32xx_sys_suspend_sz, GFP_KERNEL);
there is a minor coding style issue, which is reported by checkpatch:
CHECK: Alignment should match open parenthesis
#53: FILE: arch/arm/mach-lpc32xx/pm.c:90:
Other than that the change is valid, I'll fix the indentation issue
myself and apply the change for v4.19.
--
Best wishes,
Vladimir
> if (!iram_swap_area) {
> printk(KERN_ERR
> "PM Suspend: cannot allocate memory to save portion "
> @@ -94,10 +95,6 @@ static int lpc32xx_pm_enter(suspend_state_t state)
> return -ENOMEM;
> }
>
> - /* Backup a small area of IRAM used for the suspend code */
> - memcpy(iram_swap_area, (void *) TEMP_IRAM_AREA,
> - lpc32xx_sys_suspend_sz);
> -
> /*
> * Copy code to suspend system into IRAM. The suspend code
> * needs to run from IRAM as DRAM may no longer be available
>
next prev parent reply other threads:[~2018-08-13 12:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 2:40 [PATCH] arm:pm: Use kmemdup to replace duplicating its implementation zhong jiang
2018-08-13 12:28 ` Vladimir Zapolskiy [this message]
2018-08-13 13:07 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=37f8ff09-b0c2-5cc6-87d4-8138e7b66b32@mleia.com \
--to=vz@mleia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=slemieux.tyco@gmail.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).